Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

Issue 1843163003: [Extensions] Convert APIs to use movable types [14] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/windows.json ('k') | extensions/browser/api/usb/usb_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
index 3e3a8ed5360f34a1721cd7b0433178fc61c79e01..0b8d4afe4189b786f959568c532e1069c369ebe4 100644
--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
@@ -209,7 +209,7 @@ bool ParseContentScript(const ContentScriptDetails& script_value,
}
bool ParseContentScripts(
- std::vector<linked_ptr<ContentScriptDetails>> content_script_list,
lazyboy 2016/03/30 21:28:33 Nice fix!
+ const std::vector<ContentScriptDetails>& content_script_list,
const extensions::Extension* extension,
const HostID& host_id,
bool incognito_enabled,
@@ -220,9 +220,8 @@ bool ParseContentScripts(
return false;
std::set<std::string> names;
- for (const linked_ptr<ContentScriptDetails> script_value :
- content_script_list) {
- const std::string& name = script_value->name;
+ for (const ContentScriptDetails& script_value : content_script_list) {
+ const std::string& name = script_value.name;
if (!names.insert(name).second) {
// The name was already in the list.
*error = kDuplicatedContentScriptNamesError;
@@ -230,7 +229,7 @@ bool ParseContentScripts(
}
UserScript script;
- if (!ParseContentScript(*script_value, extension, owner_base_url, &script,
+ if (!ParseContentScript(script_value, extension, owner_base_url, &script,
error))
return false;
« no previous file with comments | « chrome/common/extensions/api/windows.json ('k') | extensions/browser/api/usb/usb_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698