Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184293003: Remove calculateStdDeviation function from Blur effect. (Closed)

Created:
6 years, 9 months ago by Savago
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove calculateStdDeviation function from Blur effect. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168507

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address reviewer's comments. #

Patch Set 3 : Nice catch! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M Source/platform/graphics/filters/FEDropShadow.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FEGaussianBlur.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FEGaussianBlur.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
pdr.
LGTM with one small nit. https://codereview.chromium.org/184293003/diff/1/Source/platform/graphics/filters/FEGaussianBlur.h File Source/platform/graphics/filters/FEGaussianBlur.h (right): https://codereview.chromium.org/184293003/diff/1/Source/platform/graphics/filters/FEGaussianBlur.h#newcode41 Source/platform/graphics/filters/FEGaussianBlur.h:41: There's an extra newline ...
6 years, 9 months ago (2014-03-05 01:37:51 UTC) #1
pdr.
On 2014/03/05 01:37:51, pdr wrote: > LGTM with one small nit. > > https://codereview.chromium.org/184293003/diff/1/Source/platform/graphics/filters/FEGaussianBlur.h > ...
6 years, 9 months ago (2014-03-05 01:38:33 UTC) #2
Savago
6 years, 9 months ago (2014-03-05 01:38:37 UTC) #3
Savago
The CQ bit was checked by a.cavalcanti@samsung.com
6 years, 9 months ago (2014-03-05 01:44:18 UTC) #4
Savago
Uploaded new patch. Thanks for the review.
6 years, 9 months ago (2014-03-05 01:44:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.cavalcanti@samsung.com/184293003/10001
6 years, 9 months ago (2014-03-05 01:46:46 UTC) #6
pdr.
The CQ bit was unchecked by pdr@chromium.org
6 years, 9 months ago (2014-03-05 01:51:27 UTC) #7
pdr.
On 2014/03/05 01:51:27, pdr wrote: > The CQ bit was unchecked by mailto:pdr@chromium.org Sorry, I ...
6 years, 9 months ago (2014-03-05 01:51:56 UTC) #8
Savago
Nice catch! :-) Just uploaded a new patch.
6 years, 9 months ago (2014-03-05 01:59:47 UTC) #9
pdr.
On 2014/03/05 01:59:47, Savago wrote: > Nice catch! :-) > > Just uploaded a new ...
6 years, 9 months ago (2014-03-05 02:00:52 UTC) #10
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-05 02:00:56 UTC) #11
commit-bot: I haz the power
Failed to trigger a try job on blink_presubmit HTTP Error 400: Bad Request
6 years, 9 months ago (2014-03-05 02:06:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.cavalcanti@samsung.com/184293003/30001
6 years, 9 months ago (2014-03-05 02:06:43 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 18:24:06 UTC) #14
Message was sent while issue was closed. 
Change committed as 168507

Powered by Google App Engine
This is Rietveld 408576698