Fix artifacts on the Apps button with CoreAnimation.

Fix artifacts on the Apps button with CoreAnimation.

Without CoreAnimation, the bookmark bar buttons got redraw
messages whenever they were damaged (like, moved around,
made visible, etc). With CoreAnimation, the bookmark bar buttons
have their drawn contents cached and therefore need to be
explicitly told to re-draw.

The function BookmarkBarController::layoutSubviews should do
this, but it only iterates through the buttons in the buttons_ array,
which skips the "apps" and "other" bookmark buttons.

This patch adds those two back in. The general question of "where
else is the apps button assumed to be part of the buttons_ array" is
not answered.

BUG=340238
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255347

[ccameron, 2014-03-06 00:56:51]

Another solution to this would be to just call cr_recursivelySetNeedsDisplay on
self at that point. Let me know if that is preferred.

[Avi (use Gerrit), 2014-03-06 03:42:48]

LGTM

https://codereview.chromium.org/184273010/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/184273010/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:486:
[otherBookmarksButton_ setNeedsDisplay:YES];
Explain with a brief comment?

[ccameron, 2014-03-06 07:06:54]

Thanks!

https://codereview.chromium.org/184273010/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/184273010/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:486:
[otherBookmarksButton_ setNeedsDisplay:YES];
On 2014/03/06 03:42:48, Avi wrote:
> Explain with a brief comment?

Done.

[ccameron, 2014-03-06 07:09:37]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-03-06 07:09:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/184273010/40001

[commit-bot: I haz the power, 2014-03-06 08:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 08:36:43]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[ccameron, 2014-03-06 09:15:52]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-03-06 09:16:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/184273010/40001

[commit-bot: I haz the power, 2014-03-06 14:30:26]

Change committed as 255347