Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1842663003: Mac: Replace uses of deprecated NSNoUnderlineStyle and NSSingleUnderlineStyle (Closed)

Created:
4 years, 8 months ago by tapted
Modified:
4 years, 8 months ago
Reviewers:
erikchen
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20160329-Mac-DeploymentTarget
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Replace uses of deprecated NSNoUnderlineStyle and NSSingleUnderlineStyle These are deprecated since 10.9. NSUnderlineStyleNone and NSUnderlineStyleSingle are drop-in replacements with the same enum value. BUG=547071 Committed: https://crrev.com/cfee06241ac5c7cb3dc59bde61a56e97fe0460cd Cr-Commit-Position: refs/heads/master@{#383824}

Patch Set 1 #

Patch Set 2 : cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M ui/app_list/cocoa/app_list_view_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/controls/hyperlink_button_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/controls/hyperlink_text_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/controls/hyperlink_text_view_unittest.mm View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tapted
4 years, 8 months ago (2016-03-29 19:51:17 UTC) #3
erikchen
lgtm
4 years, 8 months ago (2016-03-29 19:53:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842663003/20001
4 years, 8 months ago (2016-03-29 19:54:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 21:08:27 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:11:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cfee06241ac5c7cb3dc59bde61a56e97fe0460cd
Cr-Commit-Position: refs/heads/master@{#383824}

Powered by Google App Engine
This is Rietveld 408576698