ui/base/cocoa/controls/hyperlink_text_view.mm - Issue 1842663003: Mac: Replace uses of deprecated NSNoUnderlineStyle and NSSingleUnderlineStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/cocoa/controls/hyperlink_text_view.mm

Issue 1842663003: Mac: Replace uses of deprecated NSNoUnderlineStyle and NSSingleUnderlineStyle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160329-Mac-DeploymentTarget

Patch Set: cl format Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/cocoa/controls/hyperlink_text_view.mm

diff --git a/ui/base/cocoa/controls/hyperlink_text_view.mm b/ui/base/cocoa/controls/hyperlink_text_view.mm

index 2a50e0f4a9497bd2e819ecc1bf0f5074c8387d94..dd5e4504333832bdc9ba90cea4ae475c28c39d9d 100644

--- a/ui/base/cocoa/controls/hyperlink_text_view.mm

+++ b/ui/base/cocoa/controls/hyperlink_text_view.mm

@@ -162,7 +162,7 @@ const float kTextBaselineShift = -1.0;

NSUnderlineStyleAttributeName : @(YES),

NSCursorAttributeName : [NSCursor pointingHandCursor],

NSLinkAttributeName : url,

- NSUnderlineStyleAttributeName : @(NSSingleUnderlineStyle)

+ NSUnderlineStyleAttributeName : @(NSUnderlineStyleSingle)

};

[[self textStorage] addAttributes:attributes range:range];

« no previous file with comments | « ui/base/cocoa/controls/hyperlink_button_cell.mm ('k') | ui/base/cocoa/controls/hyperlink_text_view_unittest.mm » ('j') | no next file with comments »