ui/base/cocoa/controls/hyperlink_button_cell.mm - Issue 1842663003: Mac: Replace uses of deprecated NSNoUnderlineStyle and NSSingleUnderlineStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/cocoa/controls/hyperlink_button_cell.mm

Issue 1842663003: Mac: Replace uses of deprecated NSNoUnderlineStyle and NSSingleUnderlineStyle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160329-Mac-DeploymentTarget

Patch Set: cl format Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/cocoa/controls/hyperlink_button_cell.mm

diff --git a/ui/base/cocoa/controls/hyperlink_button_cell.mm b/ui/base/cocoa/controls/hyperlink_button_cell.mm

index e67e60db12eb2f27bade8d3ebf90328a32ec2da3..754be72f613bc1eaeb6ad0fa274dd5c036bf27cf 100644

--- a/ui/base/cocoa/controls/hyperlink_button_cell.mm

+++ b/ui/base/cocoa/controls/hyperlink_button_cell.mm

@@ -91,7 +91,7 @@ using hyperlink_button_cell::UnderlineBehavior;

// Creates the NSDictionary of attributes for the attributed string.

- (NSDictionary*)linkAttributes {

- NSUInteger underlineMask = NSNoUnderlineStyle;

+ NSUInteger underlineMask = NSUnderlineStyleNone;

if (underlineBehavior_ == UnderlineBehavior::ALWAYS ||

(mouseIsInside_ && [self isEnabled] &&

underlineBehavior_ == UnderlineBehavior::ON_HOVER)) {

« no previous file with comments | « ui/app_list/cocoa/app_list_view_controller.mm ('k') | ui/base/cocoa/controls/hyperlink_text_view.mm » ('j') | no next file with comments »