Refactor more clipboard/bookmark logic.

Refactor more clipboard/bookmark logic.

Move logic from bookmark_pasteboard_helper_mac.mm into clipboard_util_mac.mm.
This fixes drag and drop into the tab strip, find bar, and omnibox.

BUG=600018
Committed: https://crrev.com/f7c5cdae6cfe18aebf5d0fe8d528f64910443368
Cr-Commit-Position: refs/heads/master@{#384823}

[erikchen, 2016-04-01 22:55:27]

Description was changed from

==========
Refactor more clipboard/bookmark logic.

BUG=
==========

to

==========
Refactor more clipboard/bookmark logic.

Move logic from bookmark_pasteboard_helper_mac.mm into clipboard_util_mac.mm.

BUG=600018
==========

[erikchen, 2016-04-01 23:01:00]

Description was changed from

==========
Refactor more clipboard/bookmark logic.

Move logic from bookmark_pasteboard_helper_mac.mm into clipboard_util_mac.mm.

BUG=600018
==========

to

==========
Refactor more clipboard/bookmark logic.

Move logic from bookmark_pasteboard_helper_mac.mm into clipboard_util_mac.mm.
This fixes drag and drop for the tab strip, find bar, and omnibox.

BUG=600018
==========

[erikchen, 2016-04-01 23:01:47]

Description was changed from

==========
Refactor more clipboard/bookmark logic.

Move logic from bookmark_pasteboard_helper_mac.mm into clipboard_util_mac.mm.
This fixes drag and drop for the tab strip, find bar, and omnibox.

BUG=600018
==========

to

==========
Refactor more clipboard/bookmark logic.

Move logic from bookmark_pasteboard_helper_mac.mm into clipboard_util_mac.mm.
This fixes drag and drop into the tab strip, find bar, and omnibox.

BUG=600018
==========

[erikchen, 2016-04-01 23:03:34]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 23:04:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855583002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855583002/90001

[commit-bot: I haz the power, 2016-04-01 23:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 23:43:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[erikchen, 2016-04-02 00:02:24]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 00:02:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855583002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855583002/110001

[commit-bot: I haz the power, 2016-04-02 00:06:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 00:06:31]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-02 00:10:23]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 00:10:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855583002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855583002/130001

[erikchen, 2016-04-02 00:35:34]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 00:35:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855583002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855583002/150001

[commit-bot: I haz the power, 2016-04-02 01:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 01:34:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-02 03:34:31]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 03:34:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855583002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855583002/170001

[commit-bot: I haz the power, 2016-04-02 04:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 04:14:58]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-04-02 22:50:45]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-04-02 22:50:46]

avi: Please review.

[Avi (use Gerrit), 2016-04-02 23:09:18]

LGTM with thoughts.

https://codereview.chromium.org/1855583002/diff/170001/components/bookmarks/b...
File components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm (right):

https://codereview.chromium.org/1855583002/diff/170001/components/bookmarks/b...
components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm:226: [urls
objectAtIndex:0], [url_titles objectAtIndex:0]);
-firstObject? Don't care much, though.

https://codereview.chromium.org/1855583002/diff/170001/components/bookmarks/b...
components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm:228: item =
ui::ClipboardUtil::PasteboardItemFromUrls(urls, url_titles);
What's the diff between PasteboardItemFromUrl and PasteboardItemFromUrls? Can we
put this logic into PasteboardItemFromUrls and blindly call that everywhere?

[erikchen, 2016-04-03 02:37:29]

https://codereview.chromium.org/1855583002/diff/170001/components/bookmarks/b...
File components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm (right):

https://codereview.chromium.org/1855583002/diff/170001/components/bookmarks/b...
components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm:226: [urls
objectAtIndex:0], [url_titles objectAtIndex:0]);
On 2016/04/02 23:09:18, Avi wrote:
> -firstObject? Don't care much, though.

Done.

https://codereview.chromium.org/1855583002/diff/170001/components/bookmarks/b...
components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm:228: item =
ui::ClipboardUtil::PasteboardItemFromUrls(urls, url_titles);
On 2016/04/02 23:09:18, Avi wrote:
> What's the diff between PasteboardItemFromUrl and PasteboardItemFromUrls? Can
we
> put this logic into PasteboardItemFromUrls and blindly call that everywhere?

I had thought about that. PasteboardItemFromUrl sets more Pboardtypes, and also
sets title=url, if title was not passed it, so the behavior is pretty different.

It's possible that in the future, we will want to combine the two as a refactor,
but we should convert all the call sites first.

[erikchen, 2016-04-03 02:37:43]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-03 02:37:44]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1855583002/#ps190001
(title: "Comments from avi.")

[commit-bot: I haz the power, 2016-04-03 02:38:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855583002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855583002/190001

[commit-bot: I haz the power, 2016-04-03 03:21:05]

Committed patchset #11 (id:190001)

[commit-bot: I haz the power, 2016-04-03 03:22:03]

Description was changed from

==========
Refactor more clipboard/bookmark logic.

Move logic from bookmark_pasteboard_helper_mac.mm into clipboard_util_mac.mm.
This fixes drag and drop into the tab strip, find bar, and omnibox.

BUG=600018
==========

to

==========
Refactor more clipboard/bookmark logic.

Move logic from bookmark_pasteboard_helper_mac.mm into clipboard_util_mac.mm.
This fixes drag and drop into the tab strip, find bar, and omnibox.

BUG=600018

Committed: https://crrev.com/f7c5cdae6cfe18aebf5d0fe8d528f64910443368
Cr-Commit-Position: refs/heads/master@{#384823}
==========

[commit-bot: I haz the power, 2016-04-03 03:22:04]

Patchset 11 (id:??) landed as
https://crrev.com/f7c5cdae6cfe18aebf5d0fe8d528f64910443368
Cr-Commit-Position: refs/heads/master@{#384823}