Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1841183002: [Blimp Client] Enables verbose log for incoming and outgoing messages by default (Closed)

Created:
4 years, 8 months ago by haibinlu
Modified:
4 years, 8 months ago
Reviewers:
Kevin M, Khushal
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

so that users does not have to specify command line arguments. It generates logs: V/chromium(22041): [VERBOSE1:blimp_message_pump.cc(59)] Received <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=61379> V/chromium(22041): [VERBOSE1:blimp_connection.cc(66)] Sending <BlimpMessage type=PROTOCOL_CONTROL subtype=CHECKPOINT_ACK checkpoint_id=20 byte_size=15> BUG=596796 Committed: https://crrev.com/5ae0ee4d57c0da9a27ff1f44d4346ba5c16e2a66 Cr-Commit-Position: refs/heads/master@{#383840}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M blimp/client/app/blimp_startup.cc View 1 2 2 chunks +8 lines, -0 lines 3 comments Download
M blimp/net/blimp_connection.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M blimp/net/blimp_message_pump.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
haibinlu
4 years, 8 months ago (2016-03-29 21:04:08 UTC) #3
Khushal
https://codereview.chromium.org/1841183002/diff/40001/blimp/client/app/blimp_startup.cc File blimp/client/app/blimp_startup.cc (right): https://codereview.chromium.org/1841183002/diff/40001/blimp/client/app/blimp_startup.cc#newcode41 blimp/client/app/blimp_startup.cc:41: "vmodule", "blimp_message_pump=1, blimp_connection=1"); Should this be *blimp*? I think ...
4 years, 8 months ago (2016-03-29 21:10:04 UTC) #5
Kevin M
lgtm https://codereview.chromium.org/1841183002/diff/40001/blimp/client/app/blimp_startup.cc File blimp/client/app/blimp_startup.cc (right): https://codereview.chromium.org/1841183002/diff/40001/blimp/client/app/blimp_startup.cc#newcode41 blimp/client/app/blimp_startup.cc:41: "vmodule", "blimp_message_pump=1, blimp_connection=1"); On 2016/03/29 21:10:04, Khushal wrote: ...
4 years, 8 months ago (2016-03-29 21:11:45 UTC) #6
haibinlu1
https://codereview.chromium.org/1841183002/diff/40001/blimp/client/app/blimp_startup.cc File blimp/client/app/blimp_startup.cc (right): https://codereview.chromium.org/1841183002/diff/40001/blimp/client/app/blimp_startup.cc#newcode41 blimp/client/app/blimp_startup.cc:41: "vmodule", "blimp_message_pump=1, blimp_connection=1"); On 2016/03/29 21:10:04, Khushal wrote: > ...
4 years, 8 months ago (2016-03-29 21:11:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841183002/40001
4 years, 8 months ago (2016-03-29 21:13:31 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 22:01:19 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 22:02:45 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ae0ee4d57c0da9a27ff1f44d4346ba5c16e2a66
Cr-Commit-Position: refs/heads/master@{#383840}

Powered by Google App Engine
This is Rietveld 408576698