Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: blimp/client/app/blimp_startup.cc

Issue 1841183002: [Blimp Client] Enables verbose log for incoming and outgoing messages by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/net/blimp_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/app/blimp_startup.cc
diff --git a/blimp/client/app/blimp_startup.cc b/blimp/client/app/blimp_startup.cc
index e19ee3f0617976248820b59850f40033cf5e1637..0c2b6ecf833f13fdbfa07a10e64f88bd427f3e6b 100644
--- a/blimp/client/app/blimp_startup.cc
+++ b/blimp/client/app/blimp_startup.cc
@@ -4,6 +4,7 @@
#include "blimp/client/app/blimp_startup.h"
+#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
@@ -33,6 +34,13 @@ namespace blimp {
namespace client {
void InitializeLogging() {
+ // TODO(haibinlu): Remove this before release.
+ // Enables a few verbose log by default.
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch("vmodule")) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+ "vmodule", "blimp_message_pump=1, blimp_connection=1");
Khushal 2016/03/29 21:10:04 Should this be *blimp*? I think we have bugs for a
Kevin M 2016/03/29 21:11:45 I don't think blimp* is a good choice because we h
haibinlu1 2016/03/29 21:11:47 there will be way too many logs. feature shall cha
+ }
+
logging::LoggingSettings settings;
#if defined(OS_ANDROID)
settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
« no previous file with comments | « no previous file | blimp/net/blimp_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698