[Blimp Client] Enables verbose log for incoming and outgoing messages by default

blimp/client/app/blimp_startup.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/app/blimp_startup.h"
 
+#include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "blimp/client/app/blimp_discardable_memory_allocator.h"
 #include "blimp/client/feature/compositor/decoding_image_generator.h"
 #include "third_party/skia/include/core/SkGraphics.h"
 #include "ui/gl/gl_surface.h"
 
 class SkImageGenerator;
 
 namespace {
 base::LazyInstance<scoped_ptr<base::MessageLoopForUI>> g_main_message_loop =
     LAZY_INSTANCE_INITIALIZER;
 
 base::LazyInstance<blimp::client::BlimpDiscardableMemoryAllocator>
     g_discardable_memory_allocator = LAZY_INSTANCE_INITIALIZER;
 
 SkImageGenerator* CreateImageGenerator(SkData* data) {
   return blimp::client::DecodingImageGenerator::create(data);
 }
 
 }  // namespace
 
 namespace blimp {
 namespace client {
 
 void InitializeLogging() {
+  // TODO(haibinlu): Remove this before release.
+  // Enables a few verbose log by default.
+  if (!base::CommandLine::ForCurrentProcess()->HasSwitch("vmodule")) {
+    base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+        "vmodule", "blimp_message_pump=1, blimp_connection=1");

[Khushal, 2016/03/29 21:10:04]

Should this be *blimp*? I think we have bugs for adding logs for multiple
features as well.

[Kevin M, 2016/03/29 21:11:45]

I don't think blimp* is a good choice because we have a lot of other features
whose module names aren't prefixed by "blimp", so we'd end up having to do a lot
of whitelisting anyways.

[haibinlu1, 2016/03/29 21:11:47]

there will be way too many logs. feature shall change DVLOG to VLOG and
explicitly add itself there.

+  }
+
   logging::LoggingSettings settings;
 #if defined(OS_ANDROID)
   settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
 #else
   base::FilePath log_filename;
   PathService::Get(base::DIR_EXE, &log_filename);
   log_filename = log_filename.AppendASCII("blimp_client.log");
   settings.logging_dest = logging::LOG_TO_ALL;
   settings.log_file = log_filename.value().c_str();
   settings.delete_old = logging::DELETE_OLD_LOG_FILE;
@@ skipping 16 matching lines @@
   if (!gfx::GLSurface::InitializeOneOff())
     return false;
   SkGraphics::Init();
   SkGraphics::SetImageGeneratorFromEncodedFactory(CreateImageGenerator);
   g_main_message_loop.Get().reset(new base::MessageLoopForUI);
   return true;
 }
 
 }  // namespace client
 }  // namespace blimp