Issue 1817353007: Fix "use types" directive in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1817353007: Fix "use types" directive in modules (Closed)

Created:
4 years, 9 months ago by nickie

Modified:
4 years, 8 months ago

Reviewers:
rossberg

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@types

Target Ref:
refs/pending/heads/experimental/nikolaos/types

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix "use types" directive in modules This is based on https://codereview.chromium.org/1817353003 and also on https://codereview.chromium.org/1827763002 (from the master branch) R=rossberg@chromium.org BUG= NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	src/parsing/parser.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	test/cctest/test-parsing.cc	View		3 chunks	+19 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 1841093002 Patch 1

Issue 1841093002 Patch 20001

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nickie

4 years, 8 months ago (2016-04-18 16:19:52 UTC) #3

Patchset 1 landed MANUALLY in experimental/nikolaos/types as:
2d468a82549998aab316d1c043f7dc5a02aab81b
https://chromium.googlesource.com/v8/v8/+/2d468a82549998aab316d1c043f7dc5a02a...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages