rebaseline_server: keep going on exception in ImagePair.__init__()

rebaseline_server: keep going on exception in ImagePair.__init__()

BUG=skia:2247
NOTREECHECKS=True
NOTRY=True
TBR=borenet

Committed: http://code.google.com/p/skia/source/detail?r=13650

[epoger, 2014-03-04 00:57:00]

committing TBR

[epoger, 2014-03-04 00:57:04]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-04 00:57:07]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/184103022/1

[epoger, 2014-03-04 00:57:59]

The CQ bit was unchecked by epoger@google.com

[epoger, 2014-03-04 00:58:10]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-04 00:58:17]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/184103022/1

[commit-bot: I haz the power, 2014-03-04 00:58:23]

Change committed as 13650

[rmistry, 2014-03-04 01:04:27]

https://codereview.chromium.org/184103022/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/184103022/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results.py:404: logging.exception('got exception while
creating new ImagePair')
Drive-by comment: It would help to log the thrown exception to capture what it
was.

[borenet, 2014-03-04 12:49:42]

LGTM

https://codereview.chromium.org/184103022/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/184103022/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results.py:404: logging.exception('got exception while
creating new ImagePair')
On 2014/03/04 01:04:27, rmistry wrote:
> Drive-by comment: It would help to log the thrown exception to capture what it
> was.

Agreed.

[epoger, 2014-03-04 14:52:18]

On 2014/03/04 01:04:27, rmistry wrote:
>
https://codereview.chromium.org/184103022/diff/1/gm/rebaseline_server/results.py
> File gm/rebaseline_server/results.py (right):
> 
>
https://codereview.chromium.org/184103022/diff/1/gm/rebaseline_server/results...
> gm/rebaseline_server/results.py:404: logging.exception('got exception while
> creating new ImagePair')
> Drive-by comment: It would help to log the thrown exception to capture what it
> was.

Thanks for the suggestion.  In this particular case, the exception is already
logged earlier in the exception call stack... but there may be other cases where
it wasn't.  So I think it's a good idea to log whenever+wherever we swallow
exceptions.  Watch for a followup CL.