rebaseline_server: keep going on exception in ImagePair.__init__()

gm/rebaseline_server/results.py

 #!/usr/bin/python
 
 """
 Copyright 2013 Google Inc.
 
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 
 Repackage expected/actual GM results as needed by our HTML rebaseline viewer.
 """
@@ skipping 371 matching lines @@
           if expected_image_relative_url == actual_image_relative_url:
             updated_result_type = KEY__RESULT_TYPE__SUCCEEDED
           else:
             updated_result_type = result_type
           extra_columns_dict = {
               KEY__EXTRACOLUMN__RESULT_TYPE: updated_result_type,
               KEY__EXTRACOLUMN__BUILDER: builder,
               KEY__EXTRACOLUMN__TEST: test,
               KEY__EXTRACOLUMN__CONFIG: config,
           }
-          image_pair = imagepair.ImagePair(
-              image_diff_db=self._image_diff_db,
-              base_url=gm_json.GM_ACTUALS_ROOT_HTTP_URL,
-              imageA_relative_url=expected_image_relative_url,
-              imageB_relative_url=actual_image_relative_url,
-              expectations=expectations_dict,
-              extra_columns=extra_columns_dict)
-          all_image_pairs.add_image_pair(image_pair)
-          if updated_result_type != KEY__RESULT_TYPE__SUCCEEDED:
-            failing_image_pairs.add_image_pair(image_pair)
+          try:
+            image_pair = imagepair.ImagePair(
+                image_diff_db=self._image_diff_db,
+                base_url=gm_json.GM_ACTUALS_ROOT_HTTP_URL,
+                imageA_relative_url=expected_image_relative_url,
+                imageB_relative_url=actual_image_relative_url,
+                expectations=expectations_dict,
+                extra_columns=extra_columns_dict)
+            all_image_pairs.add_image_pair(image_pair)
+            if updated_result_type != KEY__RESULT_TYPE__SUCCEEDED:
+              failing_image_pairs.add_image_pair(image_pair)
+          except Exception:
+            logging.exception('got exception while creating new ImagePair')

[rmistry, 2014/03/04 01:04:27]

Drive-by comment: It would help to log the thrown exception to capture what it
was.

[borenet, 2014/03/04 12:49:42]

Agreed.

 
     self._results = {
       KEY__HEADER__RESULTS_ALL: all_image_pairs.as_dict(),
       KEY__HEADER__RESULTS_FAILURES: failing_image_pairs.as_dict(),
     }
 
 
 def main():
   logging.basicConfig(format='%(asctime)s %(levelname)s %(message)s',
                       datefmt='%m/%d/%Y %H:%M:%S',
@@ skipping 14 matching lines @@
   args = parser.parse_args()
   results = Results(actuals_root=args.actuals,
                     expected_root=args.expectations,
                     generated_images_root=args.workdir)
   gm_json.WriteToFile(results.get_results_of_type(KEY__HEADER__RESULTS_ALL),
                       args.outfile)
 
 
 if __name__ == '__main__':
   main()