rebaseline_server: keep going on exception in ImagePair.__init__()

gm/rebaseline_server/results.py

Index: gm/rebaseline_server/results.py
diff --git a/gm/rebaseline_server/results.py b/gm/rebaseline_server/results.py
index c7915f261df9708adb95ce4cf63cfbe0a9d704df..8ff24ecda8e3e6a8f62326adfee86c5a5023071f 100755
--- a/gm/rebaseline_server/results.py
+++ b/gm/rebaseline_server/results.py
@@ -389,16 +389,19 @@ class Results(object):
               KEY__EXTRACOLUMN__TEST: test,
               KEY__EXTRACOLUMN__CONFIG: config,
           }
-          image_pair = imagepair.ImagePair(
-              image_diff_db=self._image_diff_db,
-              base_url=gm_json.GM_ACTUALS_ROOT_HTTP_URL,
-              imageA_relative_url=expected_image_relative_url,
-              imageB_relative_url=actual_image_relative_url,
-              expectations=expectations_dict,
-              extra_columns=extra_columns_dict)
-          all_image_pairs.add_image_pair(image_pair)
-          if updated_result_type != KEY__RESULT_TYPE__SUCCEEDED:
-            failing_image_pairs.add_image_pair(image_pair)
+          try:
+            image_pair = imagepair.ImagePair(
+                image_diff_db=self._image_diff_db,
+                base_url=gm_json.GM_ACTUALS_ROOT_HTTP_URL,
+                imageA_relative_url=expected_image_relative_url,
+                imageB_relative_url=actual_image_relative_url,
+                expectations=expectations_dict,
+                extra_columns=extra_columns_dict)
+            all_image_pairs.add_image_pair(image_pair)
+            if updated_result_type != KEY__RESULT_TYPE__SUCCEEDED:
+              failing_image_pairs.add_image_pair(image_pair)
+          except Exception:
+            logging.exception('got exception while creating new ImagePair')

[rmistry, 2014/03/04 01:04:27]

Drive-by comment: It would help to log the thrown exception to capture what it
was.

[borenet, 2014/03/04 12:49:42]

Agreed.

 
     self._results = {
       KEY__HEADER__RESULTS_ALL: all_image_pairs.as_dict(),