Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address gcasto's comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc
index 58db999ab1517ca5ab14b1d84785496aeddde116..77b9ffa1c075e03b48d08b3b7d8284650cd23da4 100644
--- a/components/password_manager/core/browser/password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc
@@ -53,9 +53,12 @@ class MockPasswordManagerDriver : public PasswordManagerDriver {
MOCK_METHOD0(GetPasswordGenerationManager, PasswordGenerationManager*());
MOCK_METHOD0(GetPasswordManager, PasswordManager*());
MOCK_METHOD0(GetAutofillManager, autofill::AutofillManager*());
+ MOCK_METHOD0(GetPasswordAutofillManager, PasswordAutofillManager*());
MOCK_METHOD1(AllowPasswordGenerationForForm, void(autofill::PasswordForm*));
MOCK_METHOD1(AccountCreationFormsFound,
void(const std::vector<autofill::FormData>&));
+ MOCK_METHOD2(AcceptPasswordAutofillSuggestion,
+ void(const base::string16&, const base::string16&));
Ilya Sherman 2014/03/18 00:14:27 nit: Why add these mock methods if they're never u
Patrick Dubroy 2014/03/28 15:44:22 They are currently pure virtuals and need to be ov
Ilya Sherman 2014/03/28 21:33:34 I'd prefer that you simply override the methods wi
};
class TestPasswordManagerClient : public PasswordManagerClient {

Powered by Google App Engine
This is Rietveld 408576698