Autofill: Refactoring to support fetching password after a username is selected

components/password_manager/core/browser/password_autofill_manager.h

Index: components/password_manager/core/browser/password_autofill_manager.h
diff --git a/components/password_manager/core/browser/password_autofill_manager.h b/components/password_manager/core/browser/password_autofill_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..4df6a85ac53cf26e9f800237c7738e4ab8f25556
--- /dev/null
+++ b/components/password_manager/core/browser/password_autofill_manager.h
@@ -0,0 +1,93 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_AUTOFILL_MANAGER_H_
+#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_AUTOFILL_MANAGER_H_
+
+#include <map>
+
+#include "base/gtest_prod_util.h"
+#include "components/autofill/core/browser/autofill_manager_delegate.h"
+#include "components/autofill/core/browser/autofill_popup_delegate.h"
+#include "components/autofill/core/common/password_form_fill_data.h"
+
+class PasswordManagerClient;
+
+namespace gfx {
+class RectF;
+}
+
+// This class is responsible for filling password forms.
+class PasswordAutofillManager : public autofill::AutofillPopupDelegate {
+ public:
+  PasswordAutofillManager(
+      PasswordManagerClient* password_manager_client,
+      autofill::AutofillManagerDelegate* autofill_manager_delegate);
+  virtual ~PasswordAutofillManager();
+
+  // AutofillPopupDelegate implementation.
+  virtual void OnPopupShown() OVERRIDE;
+  virtual void OnPopupHidden() OVERRIDE;
+  virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE;
+  virtual void DidSelectSuggestion(int identifier) OVERRIDE;
+  virtual void DidAcceptSuggestion(const base::string16& value,
+                                   int identifier) OVERRIDE;
+  virtual void RemoveSuggestion(const base::string16& value,
+                                int identifier) OVERRIDE;
+  virtual void ClearPreviewedForm() OVERRIDE;
+
+  // Invoked when a password mapping is added.
+  void OnAddPasswordFormMapping(
+      const autofill::FormFieldData& field,
+      const autofill::PasswordFormFillData& fill_data);
+
+  void OnShowPasswordSuggestions(

[Ilya Sherman, 2014/03/18 00:14:27]

nit: Docs, please.

[Patrick Dubroy, 2014/03/28 15:44:22]

Done.

[Patrick Dubroy, 2014/03/28 15:44:22]

Done.

+      const autofill::FormFieldData& field,
+      const gfx::RectF& bounds,
+      const std::vector<base::string16>& suggestions,
+      const std::vector<base::string16>& realms);
+
+  // Invoked to clear any page specific cached values.
+  void Reset();
+
+ private:
+  FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest,
+                           AcceptAutofillSuggestion);

[Ilya Sherman, 2014/03/18 00:14:27]

Please avoid friending tests.  Use protected methods overridden by test-specific
subclasses instead.  This reduces the degree to which tests can mess with
internal state, which helps keep tests more sane.

[Patrick Dubroy, 2014/03/28 15:44:22]

How about adding a public ...ForTest() method? I think that's much nicer than
making the method virtual and protected, and having to create a subclass in the
test file just to change the visibility of the method.

[Ilya Sherman, 2014/03/28 21:33:34]

I personally prefer protected methods, but a public ...ForTest method is also ok
if the active owners of this component prefer it.  Both are IMO much better than
friending test code.

+
+  typedef std::map<autofill::FormFieldData, autofill::PasswordFormFillData>
+      LoginToPasswordInfoMap;
+
+  // Attempts to fill the password associated with user name |username|, and
+  // returns true if it was successful.
+  bool AcceptAutofillSuggestion(const autofill::FormFieldData& field,
+                                const base::string16& username);
+
+  // If |current_username| matches a username for one of the login mappings in
+  // |fill_data|, returns true and assigns the password to |out_password|.
+  // Otherwise, returns false and leaves |out_password| untouched.
+  bool GetPasswordForUsername(
+      const base::string16& current_username,
+      const autofill::PasswordFormFillData& fill_data,
+      base::string16* out_password);
+
+  // Finds login information for a |node| that was previously filled.
+  bool FindLoginInfo(const autofill::FormFieldData& field,
+                     autofill::PasswordFormFillData* found_password);
+
+  // The logins we have filled so far with their associated info.
+  LoginToPasswordInfoMap login_to_password_info_;
+
+  // Provides embedder-level operations on passwords. Must outlive |this|.
+  PasswordManagerClient* const password_manager_client_;  // weak
+
+  autofill::AutofillManagerDelegate* const autofill_manager_delegate_;  // weak
+
+  autofill::FormFieldData form_field_;

[Ilya Sherman, 2014/03/18 00:14:27]

nit: Docs.

[Patrick Dubroy, 2014/03/28 15:44:22]

Done.

+
+  base::WeakPtrFactory<PasswordAutofillManager> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(PasswordAutofillManager);
+};
+
+#endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_AUTOFILL_MANAGER_H_