Autofill: Refactoring to support fetching password after a username is selected

components/password_manager/core/browser/password_form_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/run_loop.h"
@@ skipping 35 matching lines @@
  public:
   MockPasswordManagerDriver() {}
   virtual ~MockPasswordManagerDriver() {}
 
   MOCK_METHOD1(FillPasswordForm, void(const autofill::PasswordFormFillData&));
   MOCK_METHOD0(DidLastPageLoadEncounterSSLErrors, bool());
   MOCK_METHOD0(IsOffTheRecord, bool());
   MOCK_METHOD0(GetPasswordGenerationManager, PasswordGenerationManager*());
   MOCK_METHOD0(GetPasswordManager, PasswordManager*());
   MOCK_METHOD0(GetAutofillManager, autofill::AutofillManager*());
+  MOCK_METHOD0(GetPasswordAutofillManager, PasswordAutofillManager*());
   MOCK_METHOD1(AllowPasswordGenerationForForm, void(autofill::PasswordForm*));
   MOCK_METHOD1(AccountCreationFormsFound,
                void(const std::vector<autofill::FormData>&));
+  MOCK_METHOD2(AcceptPasswordAutofillSuggestion,
+               void(const base::string16&, const base::string16&));

[Ilya Sherman, 2014/03/18 00:14:27]

nit: Why add these mock methods if they're never used?

[Patrick Dubroy, 2014/03/28 15:44:22]

They are currently pure virtuals and need to be overridden in all mocks. I
already opened a bug to fix this by implementing a TestPasswordManagerDriver
that contains empty implementations of all the pure virtual functions:
http://crbug.com/352566.

[Ilya Sherman, 2014/03/28 21:33:34]

I'd prefer that you simply override the methods with empty bodies if they don't
actually need to be mocked, but I won't push super hard for this.

 };
 
 class TestPasswordManagerClient : public PasswordManagerClient {
  public:
   explicit TestPasswordManagerClient(PasswordStore* password_store)
       : password_store_(password_store) {
     prefs_.registry()->RegisterBooleanPref(prefs::kPasswordManagerEnabled,
                                            true);
   }
 
@@ skipping 623 matching lines @@
 
   form_manager.ProvisionallySave(
       complete_form, PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
   // By now that form has been used once.
   complete_form.times_used = 1;
 
   // Check that PasswordStore receives an update request with the complete form.
   EXPECT_CALL(*mock_store(), UpdateLogin(complete_form));
   form_manager.Save();
 }