components/test_runner/web_test_delegate.h - Issue 1840823002: Extract WebViewClient implementation out of WebTestProxyBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_test_delegate.h

Issue 1840823002: Extract WebViewClient implementation out of WebTestProxyBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@separate-pixel-dump-code

Patch Set: Expanding a comment + an IWYU fix. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/web_test_delegate.h

diff --git a/components/test_runner/web_test_delegate.h b/components/test_runner/web_test_delegate.h

index 41da496b783b5864b45cc10c39ac953a08e46745..4e62e8add4d78b0704451fb183a9b5c6127b51c0 100644

--- a/components/test_runner/web_test_delegate.h

+++ b/components/test_runner/web_test_delegate.h

@@ -197,7 +197,7 @@ class WebTestDelegate {

virtual void SetGeofencingMockPosition(double latitude, double longitude) = 0;

// Controls which WebView should be focused.

- virtual void SetFocus(WebTestProxyBase* proxy, bool focus) = 0;

+ virtual void SetFocus(blink::WebView* web_view, bool focus) = 0;

// Controls whether all cookies should be accepted or writing cookies in a

// third-party context is blocked.

« no previous file with comments | « components/test_runner/web_frame_test_proxy.cc ('k') | components/test_runner/web_test_interfaces.h » ('j') | no next file with comments »