Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: components/test_runner/web_test_interfaces.h

Issue 1840823002: Extract WebViewClient implementation out of WebTestProxyBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@separate-pixel-dump-code
Patch Set: Expanding a comment + an IWYU fix. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_test_delegate.h ('k') | components/test_runner/web_test_interfaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_test_interfaces.h
diff --git a/components/test_runner/web_test_interfaces.h b/components/test_runner/web_test_interfaces.h
index 481c4261f952eb1b87a87e6ce8f28255e9c99de1..8b93aa8931e69ffb546b019973e192c8991457f2 100644
--- a/components/test_runner/web_test_interfaces.h
+++ b/components/test_runner/web_test_interfaces.h
@@ -33,6 +33,7 @@ class WebFrameTestClient;
class WebTestDelegate;
class WebTestProxyBase;
class WebTestRunner;
+class WebViewTestClient;
class TEST_RUNNER_EXPORT WebTestInterfaces {
public:
@@ -66,15 +67,21 @@ class TEST_RUNNER_EXPORT WebTestInterfaces {
TestInterfaces* GetTestInterfaces();
- // Gets a borrowed pointer to a WebFrameClient implementation providing
- // test behavior (i.e. forwarding javascript console output to the test
- // harness). The caller should guarantee that the returned pointer
- // won't be used beyond the lifetime of WebTestInterfaces.
- blink::WebFrameClient* GetWebFrameTestClient();
+ // Creates a WebFrameClient implementation providing test behavior (i.e.
+ // forwarding javascript console output to the test harness). The caller
+ // should guarantee that the returned object won't be used beyond the lifetime
+ // of WebTestInterfaces.
+ scoped_ptr<WebFrameTestClient> CreateWebFrameTestClient();
+
+ // Creates a WebViewClient implementation providing test behavior (i.e.
+ // providing a mocked speech recognizer). The caller should guarantee that
+ // the returned pointer won't be used beyond the lifetime of WebTestInterfaces
+ // and/or the lifetime of |web_test_proxy_base|.
+ scoped_ptr<WebViewTestClient> CreateWebViewTestClient(
+ WebTestProxyBase* web_test_proxy_base);
private:
scoped_ptr<TestInterfaces> interfaces_;
- scoped_ptr<WebFrameTestClient> web_frame_test_client_;
DISALLOW_COPY_AND_ASSIGN(WebTestInterfaces);
};
« no previous file with comments | « components/test_runner/web_test_delegate.h ('k') | components/test_runner/web_test_interfaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698