Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts.

Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts.

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=15638

[Toon Verwaest, 2013-07-11 15:23:45]

Nice cleanup. lgtm with a nit.

https://codereview.chromium.org/18404009/diff/1/src/frames-inl.h
File src/frames-inl.h (right):

https://codereview.chromium.org/18404009/diff/1/src/frames-inl.h#newcode279
src/frames-inl.h:279: ASSERT(result->IsJSFunction());
You can remove this assert, it's implicit in the cast.

https://codereview.chromium.org/18404009/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/18404009/diff/1/src/frames.cc#newcode803
src/frames.cc:803: PrintF(file, " at <unknown>:<unknown>");
Nice catch.

[titzer, 2013-07-11 15:30:19]

https://codereview.chromium.org/18404009/diff/1/src/frames-inl.h
File src/frames-inl.h (right):

https://codereview.chromium.org/18404009/diff/1/src/frames-inl.h#newcode279
src/frames-inl.h:279: ASSERT(result->IsJSFunction());
On 2013/07/11 15:23:46, Toon Verwaest wrote:
> You can remove this assert, it's implicit in the cast.

Done.

[titzer, 2013-07-11 16:46:07]

Committed patchset #2 manually as r15638 (presubmit successful).