src/liveedit.cc - Issue 18404009: Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.cc

Issue 18404009: Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove implicit ASSERT. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/liveedit.cc

diff --git a/src/liveedit.cc b/src/liveedit.cc

index 95f0b00820968665d54c314a6dd77a0e2a3db19e..bab2e101bc22d7a6ca5e39082ff0cbe0eac4155a 100644

--- a/src/liveedit.cc

+++ b/src/liveedit.cc

@@ -1621,8 +1621,7 @@ static bool CheckActivation(Handle<JSArray> shared_info_array,

LiveEdit::FunctionPatchabilityStatus status) {

if (!frame->is_java_script()) return false;

- Handle<JSFunction> function(

- JSFunction::cast(JavaScriptFrame::cast(frame)->function()));

+ Handle<JSFunction> function(JavaScriptFrame::cast(frame)->function());

Isolate* isolate = shared_info_array->GetIsolate();

int len = GetArrayLength(shared_info_array);

« no previous file with comments | « src/isolate.cc ('k') | src/runtime.cc » ('j') | no next file with comments »