Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/frames.h

Issue 18404009: Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove implicit ASSERT. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/deoptimizer.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 int offset_; 536 int offset_;
537 bool is_constructor_; 537 bool is_constructor_;
538 }; 538 };
539 539
540 540
541 class JavaScriptFrame: public StandardFrame { 541 class JavaScriptFrame: public StandardFrame {
542 public: 542 public:
543 virtual Type type() const { return JAVA_SCRIPT; } 543 virtual Type type() const { return JAVA_SCRIPT; }
544 544
545 // Accessors. 545 // Accessors.
546 inline Object* function() const; 546 inline JSFunction* function() const;
547 inline Object* receiver() const; 547 inline Object* receiver() const;
548 inline void set_receiver(Object* value); 548 inline void set_receiver(Object* value);
549 549
550 // Access the parameters. 550 // Access the parameters.
551 inline Address GetParameterSlot(int index) const; 551 inline Address GetParameterSlot(int index) const;
552 inline Object* GetParameter(int index) const; 552 inline Object* GetParameter(int index) const;
553 inline int ComputeParametersCount() const { 553 inline int ComputeParametersCount() const {
554 return GetNumberOfIncomingArguments(); 554 return GetNumberOfIncomingArguments();
555 } 555 }
556 556
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
918 }; 918 };
919 919
920 920
921 // Reads all frames on the current stack and copies them into the current 921 // Reads all frames on the current stack and copies them into the current
922 // zone memory. 922 // zone memory.
923 Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone); 923 Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone);
924 924
925 } } // namespace v8::internal 925 } } // namespace v8::internal
926 926
927 #endif // V8_FRAMES_H_ 927 #endif // V8_FRAMES_H_
OLDNEW
« no previous file with comments | « src/deoptimizer.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698