Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3516)

Unified Diff: chrome/common/extensions/docs/examples/extensions/buildbot/try_status.js

Issue 18401004: Continuously update status in the buildbot extension popup window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address initial review comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/examples/extensions/buildbot/try_status.js
diff --git a/chrome/common/extensions/docs/examples/extensions/buildbot/try_status.js b/chrome/common/extensions/docs/examples/extensions/buildbot/try_status.js
index d909d080aada4938f990064742994ca20a31614b..fa971ecd17f0a7dad2e55cd54e49e9201499471e 100644
--- a/chrome/common/extensions/docs/examples/extensions/buildbot/try_status.js
+++ b/chrome/common/extensions/docs/examples/extensions/buildbot/try_status.js
@@ -2,11 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-var RUNNING = -1;
-var SUCCESS = 0;
-var WARNINGS = 1;
-var FAILURE = 2;
-var SKIPPED = 3;
-var EXCEPTION = 4;
-var RETRY = 5;
-var NOT_STARTED = 6;
+(function() {
+
+window.RUNNING = -1;
+window.SUCCESS = 0;
+window.WARNINGS = 1;
+window.FAILURE = 2;
+window.SKIPPED = 3;
+window.EXCEPTION = 4;
+window.RETRY = 5;
+window.NOT_STARTED = 6;
not at google - send to devlin 2013/07/04 00:37:11 likewise, window.buildbot = ....
Mike Wittman 2013/07/16 17:53:19 Done.
+
+})();

Powered by Google App Engine
This is Rietveld 408576698