Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: chrome/common/extensions/docs/examples/extensions/buildbot/utils.js

Issue 18401004: Continuously update status in the buildbot extension popup window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address initial review comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/examples/extensions/buildbot/utils.js
diff --git a/chrome/common/extensions/docs/examples/extensions/buildbot/utils.js b/chrome/common/extensions/docs/examples/extensions/buildbot/utils.js
index 9805a2ee11a940f8f28efcb76752309b381e0ce3..1640e11e4a7afbd851e49e0668cfe7bc5c8416cd 100644
--- a/chrome/common/extensions/docs/examples/extensions/buildbot/utils.js
+++ b/chrome/common/extensions/docs/examples/extensions/buildbot/utils.js
@@ -2,7 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-function requestURL(url, responseType, callback, opt_errorStatusCallback) {
+(function() {
+
+window.requestURL =
+ function(url, responseType, callback, opt_errorStatusCallback) {
not at google - send to devlin 2013/07/04 00:37:11 ditto buildbot.requestURL
Mike Wittman 2013/07/16 17:53:19 Done.
var xhr = new XMLHttpRequest();
if (responseType == "json")
// WebKit doesn't handle xhr.responseType = "json" as of Chrome 25.
@@ -29,4 +32,6 @@ function requestURL(url, responseType, callback, opt_errorStatusCallback) {
xhr.open("GET", url, true);
xhr.send();
-}
+};
+
+})();

Powered by Google App Engine
This is Rietveld 408576698