Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3204)

Unified Diff: chrome/common/extensions/docs/examples/extensions/buildbot/prefs.js

Issue 18401004: Continuously update status in the buildbot extension popup window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address initial review comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/examples/extensions/buildbot/prefs.js
diff --git a/chrome/common/extensions/docs/examples/extensions/buildbot/prefs.js b/chrome/common/extensions/docs/examples/extensions/buildbot/prefs.js
index d8df783a218cc9e4067ce0c6993f2ecee8b31c0c..6b2bcc7d27a7f18720e7b580c35ea8383923754c 100644
--- a/chrome/common/extensions/docs/examples/extensions/buildbot/prefs.js
+++ b/chrome/common/extensions/docs/examples/extensions/buildbot/prefs.js
@@ -2,12 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-function Prefs() {
+(function() {
+
+window.Prefs = function() {
not at google - send to devlin 2013/07/04 00:37:11 can we namespace this? window.buildbot = window.b
Mike Wittman 2013/07/16 17:53:19 Done.
this.defaults_ = {prefs: {use_notifications: false,
try_job_username: ""}};
-}
+};
-Prefs.prototype = {
+window.Prefs.prototype = {
get_: function(key, callback) {
chrome.storage.sync.get(this.defaults_,
function (storage) {
@@ -39,3 +41,5 @@ Prefs.prototype = {
this.set_("try_job_username", try_job_username);
}
};
+
+})();

Powered by Google App Engine
This is Rietveld 408576698