Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: build/common.gypi

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Misha's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet.gypi » ('j') | components/cronet/android/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 75cf54845cd84ba6c46b139bc6a0d1610e298626..f01fc1b74a63555d9ca525f9b99a281204c6e1f0 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -612,6 +612,12 @@
# Enable FTP support by default.
'disable_ftp_support%': 0,
+ # Do not use the platform ICU alternatives by default.
+ 'use_platform_icu_alternatives%': 0,
+
+ # Do not disable brotli filter by default.
+ 'disable_brotli_filter%': 0,
+
# Use of precompiled headers on Windows.
#
# This variable may be explicitly set to 1 (enabled) or 0
@@ -1269,6 +1275,8 @@
'enable_captive_portal_detection%': '<(enable_captive_portal_detection)',
'disable_file_support%': '<(disable_file_support)',
'disable_ftp_support%': '<(disable_ftp_support)',
+ 'use_platform_icu_alternatives%': '<(use_platform_icu_alternatives)',
+ 'disable_brotli_filter%': '<(disable_brotli_filter)',
'enable_task_manager%': '<(enable_task_manager)',
'sas_dll_path%': '<(sas_dll_path)',
'wix_path%': '<(wix_path)',
@@ -3025,6 +3033,9 @@
['disable_ftp_support==1', {
'defines': ['DISABLE_FTP_SUPPORT=1'],
}],
+ ['use_platform_icu_alternatives==1', {
+ 'defines': ['USE_PLATFORM_ICU_ALTERNATIVES=1'],
brettw 2016/04/04 22:54:11 Instead of this and the place(s) you set this defi
kapishnikov 2016/04/05 15:22:04 That is nice. I will work on it.
kapishnikov 2016/04/05 22:10:15 Done. Changed to buildflag headers. The failure on
+ }],
['enable_supervised_users==1', {
'defines': ['ENABLE_SUPERVISED_USERS=1'],
}],
« no previous file with comments | « no previous file | components/cronet.gypi » ('j') | components/cronet/android/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698