Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9261)

Unified Diff: components/cronet.gypi

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Misha's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet.gypi
diff --git a/components/cronet.gypi b/components/cronet.gypi
index ce5a031a183e27f527d5cc88fe84da0d6d3f6939..abe3c275e6c6cb36bbfdf417e86d7013ac466f03 100644
--- a/components/cronet.gypi
+++ b/components/cronet.gypi
@@ -174,18 +174,12 @@
],
},
{
- # cronet_static_small target has reduced binary size through using
- # ICU alternatives which requires file and ftp support be disabled.
+ # cronet_static_small target depends on the small version of the data reduction proxy.
'target_name': 'cronet_static_small',
'type': 'static_library',
- 'defines': [
- 'USE_ICU_ALTERNATIVES_ON_ANDROID=1',
- 'DISABLE_FILE_SUPPORT=1',
- 'DISABLE_FTP_SUPPORT=1',
- ],
'dependencies': [
- '../net/net.gyp:net_small',
- '../url/url.gyp:url_lib_use_icu_alternatives_on_android',
+ '../net/net.gyp:net',
+ '../url/url.gyp:url_lib',
],
'conditions': [
['enable_data_reduction_proxy_support==1',
@@ -227,7 +221,7 @@
'dependencies': [
'cronet_static_small',
'../base/base.gyp:base',
- '../net/net.gyp:net_small',
+ '../net/net.gyp:net',
],
'ldflags': [
'-Wl,--version-script=<!(cd <(DEPTH) && pwd -P)/components/cronet/android/only_jni_exports.lst',

Powered by Google App Engine
This is Rietveld 408576698