Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: components/cronet/android/BUILD.gn

Issue 1839803002: Remove net & url small, iOS ICU alternatives, unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Misha's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index 5925423513dbac62d0450714b375ae55b2880913..edc1cb8ec163c4cb5516060388040439c390ddea 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -189,15 +189,9 @@ template("cronet_static_tmpl") {
# cronet_static_small target has reduced binary size through using
# ICU alternatives which requires file and ftp support be disabled.
cronet_static_tmpl("cronet_static_small") {
- defines = [
- "USE_ICU_ALTERNATIVES_ON_ANDROID=1",
- "DISABLE_FILE_SUPPORT=1",
- "DISABLE_FTP_SUPPORT=1",
- ]
-
deps = [
- "//net:net_small",
- "//url:url_lib_use_icu_alternatives_on_android",
+ "//net:net",
brettw 2016/04/04 22:54:11 Just "//net" and "//url" here.
kapishnikov 2016/04/05 15:22:04 Done.
+ "//url:url",
]
if (cronet_enable_data_reduction_proxy_support) {
@@ -231,7 +225,7 @@ shared_library("cronet") {
deps = [
":cronet_static_small",
"//base",
- "//net:net_small",
+ "//net:net",
]
ldflags = [ "-Wl,--version-script=" +
rebase_path("//components/cronet/android/only_jni_exports.lst") ]

Powered by Google App Engine
This is Rietveld 408576698