Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1839653002: Make SkFixed private. (Closed)

Created:
4 years, 8 months ago by dogben
Modified:
4 years, 8 months ago
Reviewers:
mtklein, bsalomon
CC:
jcgregorio, reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkFixed private. Removed from Chromium in https://codereview.chromium.org/1698083004 and https://codereview.chromium.org/1752953003. Removed from Android in 895781. Removed from Google3 in internal cl/118359061. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1839653002 Committed: https://skia.googlesource.com/skia/+/dfed06f6ff5a8e71a48a955f49deac3afd646952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -156 lines) Patch
M gyp/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
D include/core/SkFixed.h View 1 chunk +0 lines, -155 lines 0 comments Download
M include/core/SkScalar.h View 1 chunk +1 line, -1 line 0 comments Download
A + include/private/SkFixed.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839653002/1
4 years, 8 months ago (2016-03-28 16:24:43 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-28 16:35:19 UTC) #5
dogben
Do I need to make changes to keep the cmake build working?
4 years, 8 months ago (2016-03-28 16:38:54 UTC) #7
mtklein
LGTM On 2016/03/28 16:38:54, Ben Wagner wrote: > Do I need to make changes to ...
4 years, 8 months ago (2016-03-28 17:04:47 UTC) #8
dogben
+bsalomon for API change, since reed is on vacation. In previous CLs, reed has indicated ...
4 years, 8 months ago (2016-03-28 17:07:45 UTC) #10
bsalomon
lgtm
4 years, 8 months ago (2016-03-28 17:09:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839653002/1
4 years, 8 months ago (2016-03-28 17:31:11 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 17:32:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dfed06f6ff5a8e71a48a955f49deac3afd646952

Powered by Google App Engine
This is Rietveld 408576698