Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1752953003: Replace uses of SkFixed for HarfBuzz conversions. (Closed)

Created:
4 years, 9 months ago by dogben
Modified:
4 years, 9 months ago
CC:
chromium-reviews, jcgregorio, mtklein
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace uses of SkFixed for HarfBuzz conversions. We would like to make SkFixed private. BUG=skia:4632 Committed: https://crrev.com/295234e15fe991abaa61ec80de8c079dea7ad330 Cr-Commit-Position: refs/heads/master@{#379726}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-line-height-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-line-height-crash2-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/harfbuzz_font_skia.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/gfx/skia_util.h View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/gfx/skia_util.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752953003/1
4 years, 9 months ago (2016-03-02 19:32:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752953003/20001
4 years, 9 months ago (2016-03-02 19:58:50 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752953003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752953003/40001
4 years, 9 months ago (2016-03-02 20:34:55 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/176895)
4 years, 9 months ago (2016-03-02 21:19:52 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752953003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752953003/60001
4 years, 9 months ago (2016-03-03 16:33:05 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/183510)
4 years, 9 months ago (2016-03-03 19:42:36 UTC) #18
dogben
4 years, 9 months ago (2016-03-07 15:26:07 UTC) #20
drott
LGTM for third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
4 years, 9 months ago (2016-03-07 16:19:12 UTC) #21
danakj
-danakj +asvitkine for fonts
4 years, 9 months ago (2016-03-07 21:46:10 UTC) #23
Alexei Svitkine (slow)
lgtm
4 years, 9 months ago (2016-03-07 21:56:27 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752953003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752953003/60001
4 years, 9 months ago (2016-03-08 00:52:32 UTC) #26
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 9 months ago (2016-03-08 03:58:22 UTC) #27
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 03:59:29 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/295234e15fe991abaa61ec80de8c079dea7ad330
Cr-Commit-Position: refs/heads/master@{#379726}

Powered by Google App Engine
This is Rietveld 408576698