Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1698083004:
Use a more correct conversion to uint8_t. (Closed)
DescriptionUse a more correct conversion to uint8_t.
We would like to make SkDoubleToFixed private.
Committed: https://crrev.com/f48aaf9fefb5fb72db6d5b758afa0c7d177383b2
Cr-Commit-Position: refs/heads/master@{#376806}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Apply pkasting's suggestion. #Messages
Total messages: 27 (12 generated)
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698083004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
benjaminwagner@google.com changed reviewers: + danakj@chromium.org
benjaminwagner@google.com changed reviewers: + pkasting@chromium.org - danakj@chromium.org
LGTM if the below works https://codereview.chromium.org/1698083004/diff/1/ui/gfx/color_utils.cc File ui/gfx/color_utils.cc (right): https://codereview.chromium.org/1698083004/diff/1/ui/gfx/color_utils.cc#newco... ui/gfx/color_utils.cc:145: light = static_cast<uint8_t>(lightness * 255 + .5); Seems like we could replace this entire conditional with: const uint8_t light = base::saturated_cast<uint8_t>(gfx::ToRoundedInt(lightness * 255));
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698083004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698083004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698083004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698083004/20001
Is the mac_chromium_10.10_rel_ng trybot expected to fail? This is my first Chromium commit, so I'm being a bit cautious. https://codereview.chromium.org/1698083004/diff/1/ui/gfx/color_utils.cc File ui/gfx/color_utils.cc (right): https://codereview.chromium.org/1698083004/diff/1/ui/gfx/color_utils.cc#newco... ui/gfx/color_utils.cc:145: light = static_cast<uint8_t>(lightness * 255 + .5); On 2016/02/18 at 23:54:03, Peter Kasting wrote: > Seems like we could replace this entire conditional with: > > const uint8_t light = > base::saturated_cast<uint8_t>(gfx::ToRoundedInt(lightness * 255)); SGTM, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
danakj@chromium.org changed reviewers: + danakj@chromium.org
LGTM
On 2016/02/22 17:30:30, Ben Wagner wrote: > Is the mac_chromium_10.10_rel_ng trybot expected to fail? This is my first > Chromium commit, so I'm being a bit cautious. Purple almost always means something went wrong on the bot, rather than an actual test failure or the like caused by your change. You should be good to go to the CQ. (I'll check that now.)
The CQ bit was checked by pkasting@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org Link to the patchset: https://codereview.chromium.org/1698083004/#ps20001 (title: "Apply pkasting's suggestion.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698083004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698083004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use a more correct conversion to uint8_t. We would like to make SkDoubleToFixed private. ========== to ========== Use a more correct conversion to uint8_t. We would like to make SkDoubleToFixed private. Committed: https://crrev.com/f48aaf9fefb5fb72db6d5b758afa0c7d177383b2 Cr-Commit-Position: refs/heads/master@{#376806} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f48aaf9fefb5fb72db6d5b758afa0c7d177383b2 Cr-Commit-Position: refs/heads/master@{#376806} |
