third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp ('k') | third_party/WebKit/Source/web/tests/sim/SimRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp

diff --git a/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp b/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp

index 460195b434b205ae07886eaeb65dc50075f10ea0..919bf3f6cb0bc53a64b19d1969c0d9bd7dac214e 100644

--- a/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp

+++ b/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp

@@ -20,7 +20,7 @@ SimNetwork::SimNetwork()

: m_currentRequest(nullptr)

{

Platform::current()->unitTestSupport()->setLoaderDelegate(this);

- ASSERT(!s_network);

+ DCHECK(!s_network);

s_network = this;

}

@@ -33,7 +33,7 @@ SimNetwork::~SimNetwork()

SimNetwork& SimNetwork::current()

{

- ASSERT(s_network);

+ DCHECK(s_network);

return *s_network;

}

@@ -49,7 +49,7 @@ void SimNetwork::didReceiveResponse(WebURLLoaderClient* client, WebURLLoader* lo

client->didReceiveResponse(loader, response);

return;

}

- ASSERT(it->value);

+ DCHECK(it->value);

m_currentRequest = it->value;

m_currentRequest->didReceiveResponse(client, loader, response);

}