Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/web/tests/sim/SimRequest.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/sim/SimRequest.cpp
diff --git a/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp b/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp
index 31ff3b6c0890c590bcab81c28c13d723b94fef09..9aacb90f771f1a17fadf79567949b8038c697ef8 100644
--- a/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp
+++ b/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp
@@ -29,7 +29,7 @@ SimRequest::SimRequest(String url, String mimeType)
SimRequest::~SimRequest()
{
- ASSERT(!m_isReady);
+ DCHECK(!m_isReady);
}
void SimRequest::didReceiveResponse(WebURLLoaderClient* client, WebURLLoader* loader, const WebURLResponse& response)
@@ -48,20 +48,21 @@ void SimRequest::didFail(const WebURLError& error)
void SimRequest::start()
{
SimNetwork::current().servePendingRequests();
- ASSERT(m_isReady);
+ DCHECK(m_isReady);
m_client->didReceiveResponse(m_loader, m_response);
}
void SimRequest::write(const String& data)
{
- ASSERT(m_isReady && !m_error.reason);
+ DCHECK(m_isReady);
+ DCHECK(!m_error.reason);
m_totalEncodedDataLength += data.length();
m_client->didReceiveData(m_loader, data.utf8().data(), data.length(), data.length());
}
void SimRequest::finish()
{
- ASSERT(m_isReady);
+ DCHECK(m_isReady);
if (m_error.reason) {
m_client->didFail(m_loader, m_error);
} else {
« no previous file with comments | « third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698