third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp ('k') | third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp

diff --git a/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp b/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp

index 52abc190dfdd9628aee166493631f2f93826db7e..17df7e339f13217e7888eb43d6403cca086acb57 100644

--- a/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp

+++ b/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp

@@ -30,7 +30,7 @@ bool SimDisplayItemList::contains(SimCanvas::CommandType type, const String& col

{

Color color = 0;

if (!colorString.isNull())

- RELEASE_ASSERT(CSSParser::parseColor(color, colorString, true));

+ CHECK(CSSParser::parseColor(color, colorString, true));

for (auto& command : m_commands) {

if (command.type == type && (colorString.isNull() || command.color == color.rgb()))

return true;