Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp b/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
index f9b5c2328ed64c999f65153d7aa406ce9abed2b0..0ecebcffcd3630ea17bd931bfa9c2c6f1c8c7d3f 100644
--- a/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
@@ -80,21 +80,21 @@ protected:
blink::LocalFrame* frame()
{
- ASSERT(m_webViewHelper.webViewImpl());
- ASSERT(m_webViewHelper.webViewImpl()->mainFrameImpl());
+ DCHECK(m_webViewHelper.webViewImpl());
+ DCHECK(m_webViewHelper.webViewImpl()->mainFrameImpl());
return m_webViewHelper.webViewImpl()->mainFrameImpl()->frame();
}
blink::Screen* screen()
{
- ASSERT(frame());
- ASSERT(frame()->localDOMWindow());
+ DCHECK(frame());
+ DCHECK(frame()->localDOMWindow());
return frame()->localDOMWindow()->screen();
}
bool screenKeepAwake()
{
- ASSERT(screen());
+ DCHECK(screen());
return ScreenWakeLock::keepAwake(*screen());
}
@@ -105,20 +105,20 @@ protected:
void setKeepAwake(bool keepAwake)
{
- ASSERT(screen());
+ DCHECK(screen());
ScreenWakeLock::setKeepAwake(*screen(), keepAwake);
}
void show()
{
- ASSERT(m_webViewHelper.webView());
+ DCHECK(m_webViewHelper.webView());
m_webViewHelper.webView()->setVisibilityState(
blink::WebPageVisibilityStateVisible, false);
}
void hide()
{
- ASSERT(m_webViewHelper.webView());
+ DCHECK(m_webViewHelper.webView());
m_webViewHelper.webView()->setVisibilityState(
blink::WebPageVisibilityStateHidden, false);
}

Powered by Google App Engine
This is Rietveld 408576698