Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/wake_lock/ScreenWakeLock.h" 5 #include "modules/wake_lock/ScreenWakeLock.h"
6 6
7 #include "core/dom/DOMImplementation.h" 7 #include "core/dom/DOMImplementation.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/dom/DocumentInit.h" 9 #include "core/dom/DocumentInit.h"
10 #include "core/frame/LocalDOMWindow.h" 10 #include "core/frame/LocalDOMWindow.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 void loadFrame() 73 void loadFrame()
74 { 74 {
75 blink::FrameTestHelpers::loadFrame( 75 blink::FrameTestHelpers::loadFrame(
76 m_webViewHelper.webView()->mainFrame(), 76 m_webViewHelper.webView()->mainFrame(),
77 "http://example.com/foo.html"); 77 "http://example.com/foo.html");
78 m_webViewHelper.webViewImpl()->updateAllLifecyclePhases(); 78 m_webViewHelper.webViewImpl()->updateAllLifecyclePhases();
79 } 79 }
80 80
81 blink::LocalFrame* frame() 81 blink::LocalFrame* frame()
82 { 82 {
83 ASSERT(m_webViewHelper.webViewImpl()); 83 DCHECK(m_webViewHelper.webViewImpl());
84 ASSERT(m_webViewHelper.webViewImpl()->mainFrameImpl()); 84 DCHECK(m_webViewHelper.webViewImpl()->mainFrameImpl());
85 return m_webViewHelper.webViewImpl()->mainFrameImpl()->frame(); 85 return m_webViewHelper.webViewImpl()->mainFrameImpl()->frame();
86 } 86 }
87 87
88 blink::Screen* screen() 88 blink::Screen* screen()
89 { 89 {
90 ASSERT(frame()); 90 DCHECK(frame());
91 ASSERT(frame()->localDOMWindow()); 91 DCHECK(frame()->localDOMWindow());
92 return frame()->localDOMWindow()->screen(); 92 return frame()->localDOMWindow()->screen();
93 } 93 }
94 94
95 bool screenKeepAwake() 95 bool screenKeepAwake()
96 { 96 {
97 ASSERT(screen()); 97 DCHECK(screen());
98 return ScreenWakeLock::keepAwake(*screen()); 98 return ScreenWakeLock::keepAwake(*screen());
99 } 99 }
100 100
101 bool clientKeepScreenAwake() 101 bool clientKeepScreenAwake()
102 { 102 {
103 return m_testWebFrameClient.testWebWakeLockClient().keepScreenAwake(); 103 return m_testWebFrameClient.testWebWakeLockClient().keepScreenAwake();
104 } 104 }
105 105
106 void setKeepAwake(bool keepAwake) 106 void setKeepAwake(bool keepAwake)
107 { 107 {
108 ASSERT(screen()); 108 DCHECK(screen());
109 ScreenWakeLock::setKeepAwake(*screen(), keepAwake); 109 ScreenWakeLock::setKeepAwake(*screen(), keepAwake);
110 } 110 }
111 111
112 void show() 112 void show()
113 { 113 {
114 ASSERT(m_webViewHelper.webView()); 114 DCHECK(m_webViewHelper.webView());
115 m_webViewHelper.webView()->setVisibilityState( 115 m_webViewHelper.webView()->setVisibilityState(
116 blink::WebPageVisibilityStateVisible, false); 116 blink::WebPageVisibilityStateVisible, false);
117 } 117 }
118 118
119 void hide() 119 void hide()
120 { 120 {
121 ASSERT(m_webViewHelper.webView()); 121 DCHECK(m_webViewHelper.webView());
122 m_webViewHelper.webView()->setVisibilityState( 122 m_webViewHelper.webView()->setVisibilityState(
123 blink::WebPageVisibilityStateHidden, false); 123 blink::WebPageVisibilityStateHidden, false);
124 } 124 }
125 125
126 // Order of these members is important as we need to make sure that 126 // Order of these members is important as we need to make sure that
127 // m_testWebFrameClient outlives m_webViewHelper (destruction order) 127 // m_testWebFrameClient outlives m_webViewHelper (destruction order)
128 TestWebFrameClient m_testWebFrameClient; 128 TestWebFrameClient m_testWebFrameClient;
129 blink::FrameTestHelpers::WebViewHelper m_webViewHelper; 129 blink::FrameTestHelpers::WebViewHelper m_webViewHelper;
130 }; 130 };
131 131
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 ASSERT_FALSE(clientKeepScreenAwake()); 186 ASSERT_FALSE(clientKeepScreenAwake());
187 187
188 setKeepAwake(true); 188 setKeepAwake(true);
189 loadFrame(); 189 loadFrame();
190 190
191 EXPECT_FALSE(screenKeepAwake()); 191 EXPECT_FALSE(screenKeepAwake());
192 EXPECT_FALSE(clientKeepScreenAwake()); 192 EXPECT_FALSE(clientKeepScreenAwake());
193 } 193 }
194 194
195 } // namespace 195 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698