Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: third_party/WebKit/Source/web/tests/PrerenderingTest.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp b/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
index db52f42940f10d2e39fd994dcf0985bd349635bd..8e99e2c825fb03acea7b6df353c11cc82fa4653f 100644
--- a/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
+++ b/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
@@ -65,13 +65,13 @@ public:
void setExtraDataForNextPrerender(WebPrerender::ExtraData* extraData)
{
- ASSERT(!m_extraData);
+ DCHECK(!m_extraData);
m_extraData = adoptPtr(extraData);
}
WebPrerender releaseWebPrerender()
{
- ASSERT(!m_webPrerenders.empty());
+ DCHECK(!m_webPrerenders.empty());
WebPrerender retval(m_webPrerenders.front());
m_webPrerenders.pop_front();
return retval;
@@ -93,7 +93,7 @@ private:
{
prerender->setExtraData(m_extraData.leakPtr());
- ASSERT(!prerender->isNull());
+ DCHECK(!prerender->isNull());
m_webPrerenders.push_back(*prerender);
}
@@ -199,7 +199,7 @@ public:
{
Document* document = m_webViewHelper.webViewImpl()->mainFrameImpl()->frame()->document();
Element* console = document->getElementById("console");
- ASSERT(isHTMLUListElement(console));
+ DCHECK(isHTMLUListElement(console));
return *console;
}
@@ -210,13 +210,13 @@ public:
WebString consoleAt(unsigned i)
{
- ASSERT(consoleLength() > i);
+ DCHECK_GT(consoleLength(), i);
Node* item = NodeTraversal::childAt(console(), 1 + i);
- ASSERT(item);
- ASSERT(isHTMLLIElement(item));
- ASSERT(item->hasChildren());
+ DCHECK(item);
+ DCHECK(isHTMLLIElement(item));
+ DCHECK(item->hasChildren());
return item->textContent();
}
« no previous file with comments | « third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp ('k') | third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698