third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp b/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

index 34c5944488d9d5beb23829710c9ce83c5688f908..ec6ee91211441a538a4f2bcd42882e6bfef72628 100644

--- a/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

@@ -113,7 +113,7 @@ void ValidationMessageClientImpl::documentDetached(const Document& document)

void ValidationMessageClientImpl::checkAnchorStatus(Timer<ValidationMessageClientImpl>*)

{

- ASSERT(m_currentAnchor);

+ DCHECK(m_currentAnchor);

if (monotonicallyIncreasingTime() >= m_finishTime || !currentView()) {

hideValidationMessage(*m_currentAnchor);

return;

« no previous file with comments | « third_party/WebKit/Source/web/TextFinder.cpp ('k') | third_party/WebKit/Source/web/WebAXObject.cpp » ('j') | no next file with comments »