third_party/WebKit/Source/web/WebAXObject.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebAXObject.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp ('k') | third_party/WebKit/Source/web/WebArrayBufferConverter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebAXObject.cpp

diff --git a/third_party/WebKit/Source/web/WebAXObject.cpp b/third_party/WebKit/Source/web/WebAXObject.cpp

index 4df47cd978ddfc506526aba686a3aaa18bfa71b2..cdc846818b49af859eacaafe8b34a1db91983d41 100644

--- a/third_party/WebKit/Source/web/WebAXObject.cpp

+++ b/third_party/WebKit/Source/web/WebAXObject.cpp

@@ -62,7 +62,7 @@

namespace blink {

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

// It's not safe to call some WebAXObject APIs if a layout is pending.

// Clients should call updateLayoutAndCheckValidity first.

static bool isLayoutClean(Document* document)

@@ -632,7 +632,9 @@ WebRect WebAXObject::boundingBoxRect() const

if (isDetached())

return WebRect();

- ASSERT(isLayoutClean(m_private->getDocument()));

+#if DCHECK_IS_ON()

+ DCHECK(isLayoutClean(m_private->getDocument()));

+#endif

return pixelSnappedIntRect(m_private->elementRect());

}

@@ -1440,7 +1442,7 @@ void WebAXObject::wordBoundaries(WebVector<int>& starts, WebVector<int>& ends) c

WebVector<int> wordStartOffsets(wordBoundaries.size());

WebVector<int> wordEndOffsets(wordBoundaries.size());

for (size_t i = 0; i < wordBoundaries.size(); ++i) {

- ASSERT(wordBoundaries[i].isSimple());

+ DCHECK(wordBoundaries[i].isSimple());

wordStartOffsets[i] = wordBoundaries[i].anchorOffset;

wordEndOffsets[i] = wordBoundaries[i].focusOffset;

}