Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 } 106 }
107 107
108 void ValidationMessageClientImpl::documentDetached(const Document& document) 108 void ValidationMessageClientImpl::documentDetached(const Document& document)
109 { 109 {
110 if (m_currentAnchor && m_currentAnchor->document() == document) 110 if (m_currentAnchor && m_currentAnchor->document() == document)
111 hideValidationMessage(*m_currentAnchor); 111 hideValidationMessage(*m_currentAnchor);
112 } 112 }
113 113
114 void ValidationMessageClientImpl::checkAnchorStatus(Timer<ValidationMessageClien tImpl>*) 114 void ValidationMessageClientImpl::checkAnchorStatus(Timer<ValidationMessageClien tImpl>*)
115 { 115 {
116 ASSERT(m_currentAnchor); 116 DCHECK(m_currentAnchor);
117 if (monotonicallyIncreasingTime() >= m_finishTime || !currentView()) { 117 if (monotonicallyIncreasingTime() >= m_finishTime || !currentView()) {
118 hideValidationMessage(*m_currentAnchor); 118 hideValidationMessage(*m_currentAnchor);
119 return; 119 return;
120 } 120 }
121 121
122 // Check the visibility of the element. 122 // Check the visibility of the element.
123 // FIXME: Can we check invisibility by scrollable non-frame elements? 123 // FIXME: Can we check invisibility by scrollable non-frame elements?
124 IntRect newAnchorRectInViewport = currentView()->contentsToViewport(m_curren tAnchor->pixelSnappedBoundingBox()); 124 IntRect newAnchorRectInViewport = currentView()->contentsToViewport(m_curren tAnchor->pixelSnappedBoundingBox());
125 125
126 // FIXME: This intersection eliminates the part of the rect outside the root view. 126 // FIXME: This intersection eliminates the part of the rect outside the root view.
(...skipping 19 matching lines...) Expand all
146 hideValidationMessage(*m_currentAnchor); 146 hideValidationMessage(*m_currentAnchor);
147 } 147 }
148 148
149 DEFINE_TRACE(ValidationMessageClientImpl) 149 DEFINE_TRACE(ValidationMessageClientImpl)
150 { 150 {
151 visitor->trace(m_currentAnchor); 151 visitor->trace(m_currentAnchor);
152 ValidationMessageClient::trace(visitor); 152 ValidationMessageClient::trace(visitor);
153 } 153 }
154 154
155 } // namespace blink 155 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/TextFinder.cpp ('k') | third_party/WebKit/Source/web/WebAXObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698