third_party/WebKit/Source/web/ColorChooserUIController.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ColorChooserUIController.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp ('k') | third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ColorChooserUIController.cpp

diff --git a/third_party/WebKit/Source/web/ColorChooserUIController.cpp b/third_party/WebKit/Source/web/ColorChooserUIController.cpp

index cf6e0f1b2e687863dc7da05bc2fb5444e187da96..93ebd3c97a97c53b3c010e4e02da2220210eab9e 100644

--- a/third_party/WebKit/Source/web/ColorChooserUIController.cpp

+++ b/third_party/WebKit/Source/web/ColorChooserUIController.cpp

@@ -80,7 +80,7 @@ AXObject* ColorChooserUIController::rootAXObject()

void ColorChooserUIController::didChooseColor(const WebColor& color)

{

- ASSERT(m_client);

+ DCHECK(m_client);

m_client->didChooseColor(Color(static_cast<RGBA32>(color)));

}

@@ -93,7 +93,7 @@ void ColorChooserUIController::didEndChooser()

void ColorChooserUIController::openColorChooser()

{

- ASSERT(!m_chooser);

+ DCHECK(!m_chooser);

WebLocalFrameImpl* frame = WebLocalFrameImpl::fromFrame(m_frame);

WebFrameClient* webFrameClient = frame->client();

if (!webFrameClient)