third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.cpp ('k') | third_party/WebKit/Source/web/ColorChooserUIController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

diff --git a/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp b/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

index 2ffeae0ed06cf46b6bd6fe001bc98ae2fc80eaf3..bd1b92e7f228d9fa6f89f92ff12a5ecd31b99bf4 100644

--- a/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

+++ b/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

@@ -125,8 +125,8 @@ Locale& ColorChooserPopupUIController::locale()

void ColorChooserPopupUIController::setValueAndClosePopup(int numValue, const String& stringValue)

{

- ASSERT(m_popup);

- ASSERT(m_client);

+ DCHECK(m_popup);

+ DCHECK(m_client);

if (numValue == ColorPickerPopupActionSetValue)

setValue(stringValue);

if (numValue == ColorPickerPopupActionChooseOtherColor)

@@ -136,7 +136,7 @@ void ColorChooserPopupUIController::setValueAndClosePopup(int numValue, const St

void ColorChooserPopupUIController::setValue(const String& value)

{

- ASSERT(m_client);

+ DCHECK(m_client);

Color color;

bool success = color.setFromString(value);

ASSERT_UNUSED(success, success);

@@ -158,7 +158,7 @@ Element& ColorChooserPopupUIController::ownerElement()

void ColorChooserPopupUIController::openPopup()

{

- ASSERT(!m_popup);

+ DCHECK(!m_popup);

m_popup = m_chromeClient->openPagePopup(this);

}

« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.cpp ('k') | third_party/WebKit/Source/web/ColorChooserUIController.cpp » ('j') | no next file with comments »