Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp b/third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp
index 4f61b87d0d393e15fa9e5d0398dafb4af0ee1d3b..e55239a32fb49deabcba16c29f19cb17566aa4b4 100644
--- a/third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp
@@ -56,7 +56,7 @@ public:
bool isEnabled() const
{
- ASSERT(m_value != NeedsRefresh);
+ DCHECK_NE(m_value, NeedsRefresh);
return m_value == IsEnabled;
}
@@ -126,7 +126,7 @@ void ContextFeaturesCache::validateAgainst(Document* document)
bool ContextFeaturesClientImpl::isEnabled(Document* document, ContextFeatures::FeatureType type, bool defaultValue)
{
- ASSERT(document);
+ DCHECK(document);
ContextFeaturesCache::Entry& cache = ContextFeaturesCache::from(*document).entryFor(type);
if (cache.needsRefresh(defaultValue))
cache.set(askIfIsEnabled(document, type, defaultValue), defaultValue);
@@ -135,7 +135,7 @@ bool ContextFeaturesClientImpl::isEnabled(Document* document, ContextFeatures::F
void ContextFeaturesClientImpl::urlDidChange(Document* document)
{
- ASSERT(document);
+ DCHECK(document);
ContextFeaturesCache::from(*document).validateAgainst(document);
}
« no previous file with comments | « third_party/WebKit/Source/web/ColorChooserUIController.cpp ('k') | third_party/WebKit/Source/web/DatabaseClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698