google_apis/gcm/gcm_client_impl.cc - Issue 183923006: [GCM] API update to allow only a single sender in registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm_client_impl.cc

Issue 183923006: [GCM] API update to allow only a single sender in registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates based on CR. Changing how the senders/reg_ids are stored to avoid upgrade to multiple sedne… Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/gcm_client_impl.cc

diff --git a/google_apis/gcm/gcm_client_impl.cc b/google_apis/gcm/gcm_client_impl.cc

index 640977afb806f28efd0624d4a181f0d7495b2a5c..d7e5ef8ea297d8fcd43cb64ecd0de1dee92fb7cc 100644

--- a/google_apis/gcm/gcm_client_impl.cc

+++ b/google_apis/gcm/gcm_client_impl.cc

@@ -298,14 +298,14 @@ void GCMClientImpl::CheckOut() {

void GCMClientImpl::Register(const std::string& app_id,

const std::string& cert,

- const std::vector<std::string>& sender_ids) {

+ const std::string& sender_id) {

DCHECK_EQ(state_, READY);

RegistrationRequest::RequestInfo request_info(

device_checkin_info_.android_id,

device_checkin_info_.secret,

app_id,

cert,

- sender_ids);

+ sender_id);

DCHECK_EQ(0u, pending_registrations_.count(app_id));

RegistrationRequest* registration_request =