google_apis/gcm/gcm_client_impl_unittest.cc - Issue 183923006: [GCM] API update to allow only a single sender in registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm_client_impl_unittest.cc

Issue 183923006: [GCM] API update to allow only a single sender in registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates based on CR. Changing how the senders/reg_ids are stored to avoid upgrade to multiple sedne… Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/gcm_client_impl_unittest.cc

diff --git a/google_apis/gcm/gcm_client_impl_unittest.cc b/google_apis/gcm/gcm_client_impl_unittest.cc

index d45a0fc66cd9d6aad144ca6d0601ef019ae28d27..3a0b8b22108ef1f441befebd23ea67e376e119d7 100644

--- a/google_apis/gcm/gcm_client_impl_unittest.cc

+++ b/google_apis/gcm/gcm_client_impl_unittest.cc

@@ -364,9 +364,7 @@ TEST_F(GCMClientImplTest, CheckOut) {

}

TEST_F(GCMClientImplTest, RegisterApp) {

- std::vector<std::string> senders;

- senders.push_back("sender");

- gcm_client()->Register("app_id", "cert", senders);

+ gcm_client()->Register("app_id", "cert", "sender");

CompleteRegistration("reg_id");

EXPECT_EQ(REGISTRATION_COMPLETED, last_event());