google_apis/gcm/gcm_client_impl.h - Issue 183923006: [GCM] API update to allow only a single sender in registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm_client_impl.h

Issue 183923006: [GCM] API update to allow only a single sender in registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates based on CR. Changing how the senders/reg_ids are stored to avoid upgrade to multiple sedne… Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/gcm_client_impl.h

diff --git a/google_apis/gcm/gcm_client_impl.h b/google_apis/gcm/gcm_client_impl.h

index 72b86bab65f49ba9162472ec4f1e57395f802479..b094384a48aab4a97045d050860ea84a1daf0a29 100644

--- a/google_apis/gcm/gcm_client_impl.h

+++ b/google_apis/gcm/gcm_client_impl.h

@@ -59,7 +59,7 @@ class GCM_EXPORT GCMClientImpl : public GCMClient {

virtual void CheckOut() OVERRIDE;

virtual void Register(const std::string& app_id,

const std::string& cert,

- const std::vector<std::string>& sender_ids) OVERRIDE;

+ const std::string& sender_id) OVERRIDE;

virtual void Unregister(const std::string& app_id) OVERRIDE;

virtual void Send(const std::string& app_id,

const std::string& receiver_id,