Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1839193004: Run auto-formatter (autopep8) on webkitpy. (Closed)

Created:
4 years, 8 months ago by qyearsley
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, ojan, mithro
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run auto-formatter (autopep8) on webkitpy. This is a follow-up to https://codereview.chromium.org/1783073002 (run autopep8 on webkitpy/layout_tests). The main reason for this is that it increases code consistency. It would also make it easier to turn on pylint warnings when running check-webkit-style and the presubmit (http://crbug.com/598897), because it decreases the number of warnings related to formatting and whitespace. Committed: https://crrev.com/4794e48d39b9d037ed247c73135631100189d541 Cr-Commit-Position: refs/heads/master@{#384428}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1123 lines, -765 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py View 8 chunks +29 lines, -17 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py View 5 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detection.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detection_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 4 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/config/ports_mock.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/memoized_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py View 5 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py View 9 chunks +23 lines, -18 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_mock.py View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py View 11 chunks +26 lines, -22 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/sheriff_calendar_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/prettypatch.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/read_checksum_from_png_unittest.py View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/environment.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py View 5 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/profiler.py View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/profiler_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/systemhost.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/systemhost_mock.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_unittest.py View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace_mock.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace_unittest.py View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py View 5 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py View 5 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py View 5 chunks +33 lines, -31 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py View 23 chunks +51 lines, -43 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py View 8 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py View 22 chunks +85 lines, -83 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/common_unittest.py View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 47 chunks +81 lines, -60 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 35 chunks +145 lines, -123 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/text.py View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/text_unittest.py View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/xcodeproj_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/xml_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers_unittest.py View 5 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/filter.py View 5 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/filter_unittest.py View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/main.py View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/main_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/optparser.py View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/optparser_unittest.py View 6 chunks +14 lines, -15 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/patchreader_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commitannouncer.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commandtest.py View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 4 chunks +22 lines, -16 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 16 chunks +37 lines, -24 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 41 chunks +202 lines, -123 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/grammar_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/main.py View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py View 7 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py View 6 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py View 4 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py View 4 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/abstractstep.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/options.py View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 5 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/webgl/update_webgl_conformance_tests.py View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/webgl/update_webgl_conformance_tests_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
qyearsley
4 years, 8 months ago (2016-03-30 18:19:46 UTC) #2
Dirk Pranke
lgtm, though I only skimmed this ...
4 years, 8 months ago (2016-03-31 02:08:47 UTC) #4
mithro
On 2016/03/31 at 02:08:47, dpranke wrote: > lgtm, though I only skimmed this ... Also ...
4 years, 8 months ago (2016-03-31 03:27:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839193004/1
4 years, 8 months ago (2016-03-31 04:14:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/196788)
4 years, 8 months ago (2016-03-31 04:54:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839193004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839193004/20001
4 years, 8 months ago (2016-03-31 21:34:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/189219)
4 years, 8 months ago (2016-03-31 21:43:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839193004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839193004/20001
4 years, 8 months ago (2016-03-31 21:50:45 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 23:05:12 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 23:07:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4794e48d39b9d037ed247c73135631100189d541
Cr-Commit-Position: refs/heads/master@{#384428}

Powered by Google App Engine
This is Rietveld 408576698