third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py - Issue 1839193004: Run auto-formatter (autopep8) on webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

Issue 1839193004: Run auto-formatter (autopep8) on webkitpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

index 76bf236c551b9efb90bd18b4f7a0e9a7a2ce2412..ccc8983ad552115d41511012fa7e4ce13215e4e8 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

@@ -104,7 +104,8 @@ class BaselineOptimizer(object):

def read_results_by_directory(self, baseline_name):

results_by_directory = {}

- directories = reduce(set.union, map(set, [self._relative_baseline_search_paths(port, baseline_name) for port in self._ports.values()]))

+ directories = reduce(set.union, map(set, [self._relative_baseline_search_paths(

+ port, baseline_name) for port in self._ports.values()]))

for directory in directories:

path = self._join_directory(directory, baseline_name)

@@ -170,7 +171,8 @@ class BaselineOptimizer(object):

results_by_port_name = self._results_by_port_name(results_by_directory, baseline_name)

port_names_by_result = _invert_dictionary(results_by_port_name)

- new_results_by_directory = self._remove_redundant_results(results_by_directory, results_by_port_name, port_names_by_result, baseline_name)

+ new_results_by_directory = self._remove_redundant_results(

+ results_by_directory, results_by_port_name, port_names_by_result, baseline_name)

self._optimize_result_for_root(new_results_by_directory, baseline_name)

return results_by_directory, new_results_by_directory

@@ -182,7 +184,7 @@ class BaselineOptimizer(object):

# This happens if we're missing baselines for a port.

if not current_result:

- continue;

+ continue

fallback_path = self._relative_baseline_search_paths(port, baseline_name)

current_index, current_directory = self._find_in_fallbackpath(fallback_path, current_result, new_results_by_directory)