Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers_unittest.py

Issue 1839193004: Run auto-formatter (autopep8) on webkitpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org) 1 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions 4 # modification, are permitted provided that the following conditions
5 # are met: 5 # are met:
6 # 1. Redistributions of source code must retain the above copyright 6 # 1. Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # 2. Redistributions in binary form must reproduce the above copyright 8 # 2. Redistributions in binary form must reproduce the above copyright
9 # notice, this list of conditions and the following disclaimer in the 9 # notice, this list of conditions and the following disclaimer in the
10 # documentation and/or other materials provided with the distribution. 10 # documentation and/or other materials provided with the distribution.
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 def _mock_stderr_write(self, message): 49 def _mock_stderr_write(self, message):
50 self._error_messages.append(message) 50 self._error_messages.append(message)
51 51
52 def _style_checker_configuration(self): 52 def _style_checker_configuration(self):
53 """Return a StyleProcessorConfiguration instance for testing.""" 53 """Return a StyleProcessorConfiguration instance for testing."""
54 base_rules = ["-whitespace", "+whitespace/tab"] 54 base_rules = ["-whitespace", "+whitespace/tab"]
55 filter_configuration = FilterConfiguration(base_rules=base_rules) 55 filter_configuration = FilterConfiguration(base_rules=base_rules)
56 56
57 return StyleProcessorConfiguration( 57 return StyleProcessorConfiguration(
58 filter_configuration=filter_configuration, 58 filter_configuration=filter_configuration,
59 max_reports_per_category={"whitespace/tab": 2}, 59 max_reports_per_category={"whitespace/tab": 2},
60 min_confidence=3, 60 min_confidence=3,
61 output_format="vs7", 61 output_format="vs7",
62 stderr_write=self._mock_stderr_write) 62 stderr_write=self._mock_stderr_write)
63 63
64 def _error_handler(self, configuration, line_numbers=None): 64 def _error_handler(self, configuration, line_numbers=None):
65 return DefaultStyleErrorHandler(configuration=configuration, 65 return DefaultStyleErrorHandler(configuration=configuration,
66 file_path=self._file_path, 66 file_path=self._file_path,
67 increment_error_count=self._mock_increment_error_count, 67 increment_error_count=self._mock_increme nt_error_count,
68 line_numbers=line_numbers) 68 line_numbers=line_numbers)
69 69
70 def _check_initialized(self): 70 def _check_initialized(self):
71 """Check that count and error messages are initialized.""" 71 """Check that count and error messages are initialized."""
72 self.assertEqual(0, self._error_count) 72 self.assertEqual(0, self._error_count)
73 self.assertEqual(0, len(self._error_messages)) 73 self.assertEqual(0, len(self._error_messages))
74 74
75 def _call_error_handler(self, handle_error, confidence, line_number=100): 75 def _call_error_handler(self, handle_error, confidence, line_number=100):
76 """Call the given error handler with a test error.""" 76 """Call the given error handler with a test error."""
77 handle_error(line_number=line_number, 77 handle_error(line_number=line_number,
78 category=self._category, 78 category=self._category,
79 confidence=confidence, 79 confidence=confidence,
80 message="message") 80 message="message")
81 81
82 def test_eq__true_return_value(self): 82 def test_eq__true_return_value(self):
83 """Test the __eq__() method for the return value of True.""" 83 """Test the __eq__() method for the return value of True."""
84 handler1 = self._error_handler(configuration=None) 84 handler1 = self._error_handler(configuration=None)
85 handler2 = self._error_handler(configuration=None) 85 handler2 = self._error_handler(configuration=None)
86 86
87 self.assertTrue(handler1.__eq__(handler2)) 87 self.assertTrue(handler1.__eq__(handler2))
88 88
89 def test_eq__false_return_value(self): 89 def test_eq__false_return_value(self):
90 """Test the __eq__() method for the return value of False.""" 90 """Test the __eq__() method for the return value of False."""
91 def make_handler(configuration=self._style_checker_configuration(), 91 def make_handler(configuration=self._style_checker_configuration(),
92 file_path='foo.txt', increment_error_count=lambda: True, 92 file_path='foo.txt', increment_error_count=lambda: True ,
93 line_numbers=[100]): 93 line_numbers=[100]):
94 return DefaultStyleErrorHandler(configuration=configuration, 94 return DefaultStyleErrorHandler(configuration=configuration,
95 file_path=file_path, 95 file_path=file_path,
96 increment_error_count=increment_error_count, 96 increment_error_count=increment_erro r_count,
97 line_numbers=line_numbers) 97 line_numbers=line_numbers)
98 98
99 handler = make_handler() 99 handler = make_handler()
100 100
101 # Establish a baseline for our comparisons below. 101 # Establish a baseline for our comparisons below.
102 self.assertTrue(handler.__eq__(make_handler())) 102 self.assertTrue(handler.__eq__(make_handler()))
103 103
104 # Verify that a difference in any argument causes equality to fail. 104 # Verify that a difference in any argument causes equality to fail.
105 self.assertFalse(handler.__eq__(make_handler(configuration=None))) 105 self.assertFalse(handler.__eq__(make_handler(configuration=None)))
106 self.assertFalse(handler.__eq__(make_handler(file_path='bar.txt'))) 106 self.assertFalse(handler.__eq__(make_handler(file_path='bar.txt')))
107 self.assertFalse(handler.__eq__(make_handler(increment_error_count=None) )) 107 self.assertFalse(handler.__eq__(make_handler(increment_error_count=None) ))
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 configuration = self._style_checker_configuration() 140 configuration = self._style_checker_configuration()
141 error_handler = self._error_handler(configuration) 141 error_handler = self._error_handler(configuration)
142 142
143 confidence = 5 143 confidence = 5
144 144
145 # First call: usual reporting. 145 # First call: usual reporting.
146 self._call_error_handler(error_handler, confidence) 146 self._call_error_handler(error_handler, confidence)
147 self.assertEqual(1, self._error_count) 147 self.assertEqual(1, self._error_count)
148 self.assertEqual(1, len(self._error_messages)) 148 self.assertEqual(1, len(self._error_messages))
149 self.assertEqual(self._error_messages, 149 self.assertEqual(self._error_messages,
150 ["foo.h(100): message [whitespace/tab] [5]\n"]) 150 ["foo.h(100): message [whitespace/tab] [5]\n"])
151 151
152 # Second call: suppression message reported. 152 # Second call: suppression message reported.
153 self._call_error_handler(error_handler, confidence) 153 self._call_error_handler(error_handler, confidence)
154 # The "Suppressing further..." message counts as an additional 154 # The "Suppressing further..." message counts as an additional
155 # message (but not as an addition to the error count). 155 # message (but not as an addition to the error count).
156 self.assertEqual(2, self._error_count) 156 self.assertEqual(2, self._error_count)
157 self.assertEqual(3, len(self._error_messages)) 157 self.assertEqual(3, len(self._error_messages))
158 self.assertEqual(self._error_messages[-2], 158 self.assertEqual(self._error_messages[-2],
159 "foo.h(100): message [whitespace/tab] [5]\n") 159 "foo.h(100): message [whitespace/tab] [5]\n")
160 self.assertEqual(self._error_messages[-1], 160 self.assertEqual(self._error_messages[-1],
161 "Suppressing further [whitespace/tab] reports " 161 "Suppressing further [whitespace/tab] reports "
162 "for this file.\n") 162 "for this file.\n")
163 163
164 # Third call: no report. 164 # Third call: no report.
165 self._call_error_handler(error_handler, confidence) 165 self._call_error_handler(error_handler, confidence)
166 self.assertEqual(3, self._error_count) 166 self.assertEqual(3, self._error_count)
167 self.assertEqual(3, len(self._error_messages)) 167 self.assertEqual(3, len(self._error_messages))
168 168
169 def test_line_numbers(self): 169 def test_line_numbers(self):
170 """Test the line_numbers parameter.""" 170 """Test the line_numbers parameter."""
171 self._check_initialized() 171 self._check_initialized()
172 configuration = self._style_checker_configuration() 172 configuration = self._style_checker_configuration()
173 error_handler = self._error_handler(configuration, 173 error_handler = self._error_handler(configuration,
174 line_numbers=[50]) 174 line_numbers=[50])
175 confidence = 5 175 confidence = 5
176 176
177 # Error on non-modified line: no error. 177 # Error on non-modified line: no error.
178 self._call_error_handler(error_handler, confidence, line_number=60) 178 self._call_error_handler(error_handler, confidence, line_number=60)
179 self.assertEqual(0, self._error_count) 179 self.assertEqual(0, self._error_count)
180 self.assertEqual([], self._error_messages) 180 self.assertEqual([], self._error_messages)
181 181
182 # Error on modified line: error. 182 # Error on modified line: error.
183 self._call_error_handler(error_handler, confidence, line_number=50) 183 self._call_error_handler(error_handler, confidence, line_number=50)
184 self.assertEqual(1, self._error_count) 184 self.assertEqual(1, self._error_count)
185 self.assertEqual(self._error_messages, 185 self.assertEqual(self._error_messages,
186 ["foo.h(50): message [whitespace/tab] [5]\n"]) 186 ["foo.h(50): message [whitespace/tab] [5]\n"])
187 187
188 # Error on non-modified line after turning off line filtering: error. 188 # Error on non-modified line after turning off line filtering: error.
189 error_handler.turn_off_line_filtering() 189 error_handler.turn_off_line_filtering()
190 self._call_error_handler(error_handler, confidence, line_number=60) 190 self._call_error_handler(error_handler, confidence, line_number=60)
191 self.assertEqual(2, self._error_count) 191 self.assertEqual(2, self._error_count)
192 self.assertEqual(self._error_messages, 192 self.assertEqual(self._error_messages,
193 ['foo.h(50): message [whitespace/tab] [5]\n', 193 ['foo.h(50): message [whitespace/tab] [5]\n',
194 'foo.h(60): message [whitespace/tab] [5]\n', 194 'foo.h(60): message [whitespace/tab] [5]\n',
195 'Suppressing further [whitespace/tab] reports for thi s file.\n']) 195 'Suppressing further [whitespace/tab] reports for this file.\n'])
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698