Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1839013002: Distingush between displayed and remote playback state. (Closed)

Created:
4 years, 8 months ago by aberent
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Distingush between displayed and remote playback state. Fixes two of the problems causing bug 593669. distinguishes between the displayed playback state (which, for example swiches to paused as soon as the pause button is pressed) and the remote playback state. Hence avoids side effects when the only the displayed playback state changes. Also prevents pause being sent to Chromecast too early. BUG=593669 Review URL: https://codereview.chromium.org/1822653002 Cr-Commit-Position: refs/heads/master@{#383082} (cherry picked from commit 829655949350c19eea8231f2e2da34679bc42d21) Committed: https://chromium.googlesource.com/chromium/src/+/7d077eb4b5ffc7b874bdf020e39cca24f55966cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -83 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java View 8 chunks +42 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java View 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaRouteController.java View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteControllerTest.java View 3 chunks +5 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aberent
4 years, 8 months ago (2016-03-29 09:43:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d077eb4b5ffc7b874bdf020e39cca24f55966cf.

Powered by Google App Engine
This is Rietveld 408576698